Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weird behaviour when volume was 0, and we unmute #8184

Closed
MarianoFacundoArch opened this issue Feb 27, 2025 · 0 comments · Fixed by #8186
Closed

Weird behaviour when volume was 0, and we unmute #8184

MarianoFacundoArch opened this issue Feb 27, 2025 · 0 comments · Fixed by #8186
Assignees
@avelad
Labels
component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Milestone
v4.14

Comments

@MarianoFacundoArch
Copy link
Contributor

For example, in shaka demos

Here

The reproduction step is easy, with the slider set the volume to 0, and then click unmute.
The expected behavior would be like youtube, to unmute to 100% volume. Instead it just changes the icon to unmuted while keeping the volume to 0
@MarianoFacundoArch MarianoFacundoArch added the type: bug Something isn't working correctly label Feb 27, 2025
@shaka-bot shaka-bot added this to the v4.14 milestone Feb 27, 2025
@avelad avelad added component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround labels Feb 28, 2025
@avelad avelad self-assigned this Feb 28, 2025
@avelad avelad mentioned this issue Feb 28, 2025
Merged
@avelad avelad closed this as completed in 3ff0e28 Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@avelad avelad

Labels
component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.14
Development

Successfully merging a pull request may close this issue.

fix(UI): Fix weird behaviour when volume was 0, and we unmute avelad/shaka-player
3 participants
@avelad @shaka-bot @MarianoFacundoArch