fix xpc string bug

Author: shakfu

help/xpyc.maxhelp

@@ -13,14 +13,26 @@
 		"rect" : [ 81.0, 109.0, 640.0, 480.0 ],
 		"gridsize" : [ 15.0, 15.0 ],
 		"boxes" : [ 			{
+				"box" : 				{
+					"id" : "obj-21",
+					"maxclass" : "message",
+					"numinlets" : 2,
+					"numoutlets" : 1,
+					"outlettype" : [ "" ],
+					"patching_rect" : [ 309.5, 229.0, 80.0, 22.0 ],
+					"text" : "request str(1)"
+				}
+
+			}
+, 			{
 				"box" : 				{
 					"id" : "obj-17",
 					"maxclass" : "message",
 					"numinlets" : 2,
 					"numoutlets" : 1,
 					"outlettype" : [ "" ],
-					"patching_rect" : [ 309.5, 195.0, 128.0, 22.0 ],
-					"text" : "request \\\"abc\\\".upper()"
+					"patching_rect" : [ 309.5, 195.0, 135.0, 22.0 ],
+					"text" : "request sum.__name__"
 				}
 
 			}
@@ -104,7 +116,7 @@
 					"numoutlets" : 1,
 					"outlettype" : [ "" ],
 					"patching_rect" : [ 51.0, 279.0, 108.0, 22.0 ],
-					"text" : "nan"
+					"text" : "sum"
 				}
 
 			}
@@ -199,8 +211,8 @@
 					"maxclass" : "comment",
 					"numinlets" : 1,
 					"numoutlets" : 0,
-					"patching_rect" : [ 23.0, 17.0, 578.0, 24.0 ],
-					"text" : "xpyc: an xpc client embedded in an external (now just addition of two numbers)"
+					"patching_rect" : [ 23.0, 17.0, 325.0, 24.0 ],
+					"text" : "xpyc: an xpc client embedded in an external"
 				}
 
 			}
@@ -323,6 +335,13 @@
 					"source" : [ "obj-2", 0 ]
 				}
 
+			}
+, 			{
+				"patchline" : 				{
+					"destination" : [ "obj-1", 0 ],
+					"source" : [ "obj-21", 0 ]
+				}
+
 			}
 , 			{
 				"patchline" : 				{

source/projects/xpyc/services/PythonService/main.c

@@ -100,11 +100,13 @@ void evaluate_python(xpc_object_t reply, const char* code)
         long result = PyLong_AsLong(pval);
         xpc_dictionary_set_int64(reply, "result_type", (long)value_type);
         xpc_dictionary_set_int64(reply, "result", result);
+
     } else if(PyFloat_Check(pval)) {
         double result = PyFloat_AsDouble(pval);
         ValueType value_type = get_pyobject_type(pval);
         xpc_dictionary_set_int64(reply, "result_type", (long)value_type);
         xpc_dictionary_set_double(reply, "result", result);
+
     } else if(PyUnicode_Check(pval)) {
         const char* result = PyUnicode_AsUTF8(pval);
         if (result == NULL) {
@@ -114,6 +116,9 @@ void evaluate_python(xpc_object_t reply, const char* code)
         xpc_dictionary_set_int64(reply, "result_type", (long)value_type);
         xpc_dictionary_set_string(reply, "result", result);
     }
+    else {
+        // do nothing        
+    }
     goto finally;
 
 error:

source/projects/xpyc/xpyc.c

@@ -252,13 +252,14 @@ void xpyc_request(t_xpyc* x, t_symbol* s, int argc, t_atom* argv)
         post("result: %lld", result);
         outlet_int(x->outlet, result);;        
     }
-    else if (result_type = XPYC_TYPE_DOUBLE) {
+
+    else if (result_type == XPYC_TYPE_DOUBLE) {
         double result = xpc_dictionary_get_double(reply, "result");
         post("result: %f", result);
-        outlet_float(x->outlet, result);;                
+        outlet_float(x->outlet, result);
     }
 
-    else if (result_type = XPYC_TYPE_STRING) {
+    else if (result_type == XPYC_TYPE_STRING) {
         const char* result = xpc_dictionary_get_string(reply, "result");
         post("result: %s", result);
         outlet_anything(x->outlet, gensym(result), 0, NIL);