Skip to content

Commit a026a0f

Browse files
committed
Fix article detection
1 parent 6fd0ad9 commit a026a0f

File tree

2 files changed

+14
-14
lines changed

2 files changed

+14
-14
lines changed

src/FBT Extension/script.js

+6-6
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,14 @@ window.addEventListener('keydown', function(event) {
2424
for (var i = 0; i < articles.length; i++) {
2525
article = articles[i];
2626
var rect = article.getBoundingClientRect();
27+
if (debug) console.log(article, rect, window.innerHeight);
2728
if (rect.top < window.innerHeight && rect.bottom >= 0) {
28-
// partially visible, but keep going to find last one
2929
currentArticle = article;
30+
break;
3031
}
31-
}
32+
}
3233

33-
var url = '';
34+
var url = '';
3435
if (currentArticle) {
3536
if (debug) console.log('[feedly background tabs] current article:');
3637
if (debug) console.log(currentArticle);
@@ -42,7 +43,7 @@ window.addEventListener('keydown', function(event) {
4243
currentChild = children[i];
4344
if (currentChild.classList.contains("entryTitle") ||
4445
currentChild.classList.contains("Article__title--read") ||
45-
currentChild.classList.contains("ArticleTitle")) {
46+
currentChild.classList.contains("ArticleTitle--read")) {
4647
if (debug) console.log('[feedly background tabs] found url on anchor:');
4748
if (debug) console.log(currentChild);
4849
url = currentChild.getAttribute('href');
@@ -78,8 +79,7 @@ window.addEventListener('keydown', function(event) {
7879

7980

8081
function messageHandler(event) {
81-
console.log(event)
82-
if (debug) console.log('[feedly background tabs] ' + event);
82+
if (debug) console.log('[feedly background tabs] ' + event);
8383
if (event.name === 'settings') {
8484
shortcutKey = event.message.shortcutKey;
8585
if (debug) console.log('[feedly background tabs] shortcut key is ' + shortcutKey);

src/FBT RSS Background Tabs.xcodeproj/project.pbxproj

+8-8
Original file line numberDiff line numberDiff line change
@@ -423,7 +423,7 @@
423423
CODE_SIGN_ENTITLEMENTS = Feedly_Background_Tabs.entitlements;
424424
CODE_SIGN_IDENTITY = "Mac Developer";
425425
CODE_SIGN_STYLE = Automatic;
426-
CURRENT_PROJECT_VERSION = 25;
426+
CURRENT_PROJECT_VERSION = 26;
427427
DEAD_CODE_STRIPPING = YES;
428428
DEVELOPMENT_TEAM = 6236H6BCAU;
429429
ENABLE_HARDENED_RUNTIME = YES;
@@ -434,7 +434,7 @@
434434
"@executable_path/../../../../Frameworks",
435435
);
436436
MACOSX_DEPLOYMENT_TARGET = 11.0;
437-
MARKETING_VERSION = 1.1.4;
437+
MARKETING_VERSION = 1.1.5;
438438
PRODUCT_BUNDLE_IDENTIFIER = io.mswd.feedlybackgroundtabs.extension;
439439
PRODUCT_NAME = "$(TARGET_NAME)";
440440
PROVISIONING_PROFILE_SPECIFIER = "";
@@ -449,7 +449,7 @@
449449
CODE_SIGN_ENTITLEMENTS = Feedly_Background_Tabs.entitlements;
450450
CODE_SIGN_IDENTITY = "Mac Developer";
451451
CODE_SIGN_STYLE = Automatic;
452-
CURRENT_PROJECT_VERSION = 25;
452+
CURRENT_PROJECT_VERSION = 26;
453453
DEAD_CODE_STRIPPING = YES;
454454
DEVELOPMENT_TEAM = 6236H6BCAU;
455455
ENABLE_HARDENED_RUNTIME = YES;
@@ -460,7 +460,7 @@
460460
"@executable_path/../../../../Frameworks",
461461
);
462462
MACOSX_DEPLOYMENT_TARGET = 11.0;
463-
MARKETING_VERSION = 1.1.4;
463+
MARKETING_VERSION = 1.1.5;
464464
PRODUCT_BUNDLE_IDENTIFIER = io.mswd.feedlybackgroundtabs.extension;
465465
PRODUCT_NAME = "$(TARGET_NAME)";
466466
PROVISIONING_PROFILE_SPECIFIER = "";
@@ -477,7 +477,7 @@
477477
CODE_SIGN_IDENTITY = "Mac Developer";
478478
CODE_SIGN_STYLE = Automatic;
479479
COMBINE_HIDPI_IMAGES = YES;
480-
CURRENT_PROJECT_VERSION = 25;
480+
CURRENT_PROJECT_VERSION = 26;
481481
DEAD_CODE_STRIPPING = YES;
482482
DEVELOPMENT_TEAM = 6236H6BCAU;
483483
ENABLE_HARDENED_RUNTIME = YES;
@@ -487,7 +487,7 @@
487487
"@executable_path/../Frameworks",
488488
);
489489
MACOSX_DEPLOYMENT_TARGET = 11.0;
490-
MARKETING_VERSION = 1.1.4;
490+
MARKETING_VERSION = 1.1.5;
491491
PRODUCT_BUNDLE_IDENTIFIER = io.mswd.feedlybackgroundtabs;
492492
PRODUCT_NAME = "$(TARGET_NAME)";
493493
PROVISIONING_PROFILE_SPECIFIER = "";
@@ -503,7 +503,7 @@
503503
CODE_SIGN_IDENTITY = "Mac Developer";
504504
CODE_SIGN_STYLE = Automatic;
505505
COMBINE_HIDPI_IMAGES = YES;
506-
CURRENT_PROJECT_VERSION = 25;
506+
CURRENT_PROJECT_VERSION = 26;
507507
DEAD_CODE_STRIPPING = YES;
508508
DEVELOPMENT_TEAM = 6236H6BCAU;
509509
ENABLE_HARDENED_RUNTIME = YES;
@@ -513,7 +513,7 @@
513513
"@executable_path/../Frameworks",
514514
);
515515
MACOSX_DEPLOYMENT_TARGET = 11.0;
516-
MARKETING_VERSION = 1.1.4;
516+
MARKETING_VERSION = 1.1.5;
517517
PRODUCT_BUNDLE_IDENTIFIER = io.mswd.feedlybackgroundtabs;
518518
PRODUCT_NAME = "$(TARGET_NAME)";
519519
PROVISIONING_PROFILE_SPECIFIER = "";

0 commit comments

Comments
 (0)