-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is this still maintained? #46
Comments
Afaik this package is pretty obsolete. If you're using it and need a dep update, please submit a PR and I'll publish a new version. |
I have made a PR to make this library compatible with Mocha v10. See #48 This package hosts hundreds of tests in an open source project, and it's mission critical for us to keep this library up to date. We are on the process of migrating our Mocha tests to Playwright. |
If you encounter this
This might help: diff --git a/node_modules/mocha-chrome/lib/client.js b/node_modules/mocha-chrome/lib/client.js
index 7629126..cd3d163 100644
--- a/node_modules/mocha-chrome/lib/client.js
+++ b/node_modules/mocha-chrome/lib/client.js
@@ -9,7 +9,7 @@ module.exports = async function connectClient(instance, log, options) {
return fs.readFileSync(filePath, 'utf-8');
}
- const client = await CDP({ port: instance.port });
+ const client = await CDP({ port: instance.port, host: '127.0.0.1' });
const { DOM, DOMStorage, Console, Network, Page, Runtime } = client;
const mochaOptions = `window.mochaOptions = ${JSON.stringify(options.mocha)}`;
Footnotes
|
Just wondering if anybody is still maintaining this.
There's a security issue because mocha-chrome depends on an old version of minimist.
The text was updated successfully, but these errors were encountered: