Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move version SSOT to pyproject.toml #2376

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Move version SSOT to pyproject.toml #2376

wants to merge 1 commit into from
+4 −3

Conversation

bytexenon
Copy link
Contributor

I tested this on Linux, and I'm pretty sure it should work on Windows too. I'll test it on Windows later and make any needed tweaks if something's not right.

Let me know if you spot anything that needs changing

Closes #2229

@bytexenon
Copy link
Contributor Author

Update: Just tested this on Windows. Grabbed the ZIP file from my branch, extracted it to a folder, opened the terminal in Sherlock's root directory, and ran python -m pipx install . --force. Then did a quick sherlock --version check, and, it worked:
image

Next, I switched the version field in pyproject.toml to 6.6.6, re-installed Sherlock, and it also worked:
image

So yeah, looks like it's all good on Windows (at least when installing through pipx)

@ppfeister
Copy link
Member

Hm. I did exactly this when writing it the first time, and had to use this weird workaround instead due to some niche devel issue... I don't have that reason written anywhere though... let me see if I can figure out what the blocker was and get back.

If that blocker is no longer present, this is 100% the better way to do things, I just don't want to forget anything here and cause something to break.

@ppfeister ppfeister self-assigned this Feb 3, 2025
@ppfeister ppfeister added the enhancement New feature or request label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Icantcode45 Icantcode45 Icantcode45 approved these changes

@ppfeister ppfeister Awaiting requested review from ppfeister ppfeister is a code owner

@sdushantha sdushantha Awaiting requested review from sdushantha sdushantha is a code owner

Assignees

@ppfeister ppfeister

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improved single source of truth for versioning
3 participants
@bytexenon @ppfeister @Icantcode45