Skip to content
This repository has been archived by the owner on Oct 9, 2024. It is now read-only.

Improve usage of custom Prism themes #387

Open
gregone opened this issue Oct 27, 2021 · 3 comments
Open

Improve usage of custom Prism themes #387

gregone opened this issue Oct 27, 2021 · 3 comments

Comments

@gregone
Copy link

gregone commented Oct 27, 2021

As I found when working on MelSumner/ember-a11y-for#14 , using a non-standard theme (i.e not in the main prismjs package) is quite convoluted.

Having the option to not include any css when explicitly using 'none' instead of the default theme would help some of these issues.

see:

if (theme && theme !== 'none') {

@RobbieTheWagner
Copy link
Member

@gregone would you be interested in opening a PR to fix the issue?

@gregone
Copy link
Author

gregone commented Nov 2, 2021

@rwwagner90 Sure, I can do that. Would it be ok if made theme: 'none' work as expected, i.e no css at all?

@RobbieTheWagner
Copy link
Member

@gregone could we do theme: false instead perhaps?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants