Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow trusted proxies to be configured #2360

Open
acelaya opened this issue Feb 14, 2025 · 0 comments
Open

Allow trusted proxies to be configured #2360

acelaya opened this issue Feb 14, 2025 · 0 comments
Labels
Milestone

Comments

@acelaya
Copy link
Member

acelaya commented Feb 14, 2025

Summary

#2351 highlighted the fact that a change in akrabat/ip-address-middleware made Shlink stop detecting the visitor's IP address when using more than one reverse proxy.

That was temporarily solved with a workaround, but we should allow people configure a list of trusted proxies, and disable the workaround in that case.

Use case

Support Shlink instances that are served behind multiple reverse proxies, and continue detecting the visitor's IP address without the risk of a side effect or regression, introduced by the workaround that reverses the list of IPs in X-Forwarded-For.

@acelaya acelaya added this to the 4.5.0 milestone Feb 14, 2025
@acelaya acelaya added this to Shlink Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

1 participant