Specifying percentage for "all" breaks if both FORTDIR and LOCFORTDIR have fortunes #79
Comments
|
Thanks for the report. I reproduced the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Demonstration:
This seems to be because FORTDIR and LOCFORTDIR both get separately added with the specified pecentage, instead of sharing the 70% between the two, so it effectively interprets it as
fortune 70% <locfortdir> 70% <fortdir>.I don't think fixing this is as simple as halving the percentage, since if the two directories have different numbers of fortunes, each fortunes in FORTDIR would have a different probability of showing up compared to ones in LOCFORTDIR. This would differ from what I'd expect if all the fortunes were in the same directory, where e.g.
fortune 70% ./dirwould still mean every fortune in dir has a roughly equal chance of appearing.The text was updated successfully, but these errors were encountered: