Skip to content
This repository has been archived by the owner on Jun 23, 2019. It is now read-only.

Show the actual month of the selected date #48

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

whoislyuboanyway
Copy link
Contributor

No description provided.

@whoislyuboanyway
Copy link
Contributor Author

dev note: I implemented the missing functionality to show the correct month for the selected date. Please, keep in mind, that this is quick solution, and you can close the PR if you think it's not worth it :)

public enum MonthType { case previous, current, next }
public enum MonthType: Equatable { case previous, current, next, specific(diff: Int) }
public func ==(lhs: MonthType, rhs: MonthType) -> Bool {
switch (lhs, rhs) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should define this function in MonthType.

@@ -8,7 +8,7 @@

Pod::Spec.new do |s|
s.name = 'Koyomi'
s.version = '1.2.7'
s.version = '1.2.8'
s.summary = 'Simple customizable calendar component in Swift'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change shouldn't be included in this pull request.

@shoheiyokoyama
Copy link
Owner

@whoislyuboanyway
Thank you for contributing 👍.
Can you describe the contents of the bug in more detail in this pr or related issues?

@whoislyuboanyway
Copy link
Contributor Author

This is not a bug, I just added a specific enum case, where the month skip can be more than one month prior/after :) I needed it for the project I am working on, so I updated it.

p.s. so far I always moved the Equatable method outside of the equatable object :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants