Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question: project dump: add --quick option #461

Open
m-waes opened this issue Feb 1, 2025 · 0 comments · May be fixed by #463
Open

Question: project dump: add --quick option #461

m-waes opened this issue Feb 1, 2025 · 0 comments · May be fixed by #463

Comments

@m-waes
Copy link

m-waes commented Feb 1, 2025

Hi,

I'm about to dump a rather large database, with sizes per table up to 9gb and did some research, if that can affect the production system.
I came across the --quick option for mysqldump: https://dev.mysql.com/doc/refman/8.4/en/mysqldump.html#option_mysqldump_quick

And it seems like the underlying go lib here supports that flag as well? https://github.com/doutorfinancas/go-mad/blob/master/database/option.go#L22-L23

I have no detailed experience with that flag, e.g. I don't know if there are drawbacks or collisions with other flags. I just wondered if it might be worth supporting?

I think I'll give the command a try as is, maybe it doesn't matter. I just definitely know, that our largest tables wont fit in RAM if that's required for the dump command without --quick.
shyim added a commit that referenced this issue Feb 1, 2025
@shyim
Add --quick option to project dump command
f9dee6e 
Related to #461

Add support for the --quick option in the project database dump command.

* Add a new flag `--quick` to the `projectDatabaseDumpCmd` command.
* Pass the `--quick` option to the `database.NewMySQLDumper` function when the `--quick` flag is set.
* Update the list of supported options in `cmd/project/project_database_dump.go` to include the `--quick` option.
* Modify the `cmd/project/project_database_dump.go` file to handle the `--quick` flag and pass it to the database dumper.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/shopware/shopware-cli/issues/461?shareId=XXXX-XXXX-XXXX-XXXX).
@shyim shyim mentioned this issue Feb 1, 2025
Closed
shyim added a commit that referenced this issue Feb 1, 2025
@shyim
Add --quick option to project dump command
9fd67b6 
Fixes #461

Add support for the --quick option in the project dump command.

* Add a new flag `--quick` to the `projectDatabaseDumpCmd` command.
* Pass the `--quick` option to the `database.NewMySQLDumper` function when the `--quick` flag is set.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/shopware/shopware-cli/issues/461?shareId=XXXX-XXXX-XXXX-XXXX).
@shyim shyim linked a pull request Feb 1, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add --quick option to project dump command shopware/shopware-cli
1 participant
@m-waes