Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: setup playwright #124

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

chintankavathia
Copy link
Member

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@chintankavathia chintankavathia force-pushed the ci/playwright-setup branch 10 times, most recently from b51038a to 552cd0e Compare November 15, 2024 10:39
@chintankavathia chintankavathia marked this pull request as ready for review November 15, 2024 11:42
playwright/reporters/playwright-axe-reporter.ts Outdated Show resolved Hide resolved
playwright.config.ts Outdated Show resolved Hide resolved
playwright.config.ts Outdated Show resolved Hide resolved
playwright/support/test-helpers.ts Outdated Show resolved Hide resolved
playwright/e2e/static.spec.ts Outdated Show resolved Hide resolved
src/app/app-routing.module.ts Show resolved Hide resolved
@chintankavathia chintankavathia force-pushed the ci/playwright-setup branch 4 times, most recently from 356e28e to d6c55fa Compare November 19, 2024 07:39
@spike-rabbit
Copy link
Collaborator

Just two things:

  • please avoid at least API changes in this MR. Disabling checks should be fine
  • use git lfs to store screenshots

@chintankavathia chintankavathia force-pushed the ci/playwright-setup branch 6 times, most recently from 3e33a96 to dcbe518 Compare November 26, 2024 12:05
@chintankavathia chintankavathia force-pushed the ci/playwright-setup branch 4 times, most recently from 2f3cd2e to bc76f12 Compare November 28, 2024 12:59
@chintankavathia chintankavathia force-pushed the ci/playwright-setup branch 10 times, most recently from beb7d2a to 3561044 Compare December 3, 2024 05:05
Copy link
Collaborator

@spike-rabbit spike-rabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we have some a11y issues which we should address in another MR soon.

.github/workflows/test_and_deploy.yml Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
playwright.config.ts Outdated Show resolved Hide resolved
playwright.config.ts Outdated Show resolved Hide resolved
playwright/support/test-helpers.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@spike-rabbit spike-rabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx a ton for the this. Should help us a lot to move on without breaking things.

Added support for playwright e2e tests.
@spike-rabbit spike-rabbit merged commit c94af51 into siemens:master Dec 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants