Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding resource limits to the services deployed by KFD #329

Open
woopla opened this issue Dec 20, 2024 · 0 comments
Open

Adding resource limits to the services deployed by KFD #329

woopla opened this issue Dec 20, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@woopla
Copy link

woopla commented Dec 20, 2024

Is your feature request related to a problem? Please describe.
After installing a KFD cluster, we want to validate it for correctness, so we ran popeye. Among the things reported by the tool, there's a descent amount [POP-106] No resources requests/limits defined messages. This is preventing accurate resource monitoring, and cluster autoscaling down the line.

Describe the solution you'd like
All the modules should have default limits, which can be overridden.

Describe alternatives you've considered
It should be possible to post-process with kubectl set resources, but having a properly vetted set of defaults is always better.

@woopla woopla added the enhancement New feature or request label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant