Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Notion video uploads into ReactPlayer links like you do for YouTube embeds #65

Open
turntable-justin opened this issue Aug 7, 2023 · 0 comments
Assignees

Comments

@turntable-justin
Copy link

turntable-justin commented Aug 7, 2023

Describe the bug
When converting videos uploaded to notion, they are rendered like

[image](https://s3.{region}.amazonaws.com/secure.notion-static.com/.../{filename}.mp4?...)

** Reproduction Steps **
Just try to add a video upload into Notion (not a Youtube link) and try to do conversion using yarn pull

Expected behavior
Render similar to YouTube links, i.e.

<ReactPlayer controls url="https://s3.{region}.amazonaws.com/secure.notion-static.com/.../{filename}.mp4?..." />

I tested this solution by manually editing the .md files and it seems to work.

@hatton hatton self-assigned this Aug 13, 2023
andrew-polk added a commit that referenced this issue Aug 14, 2023
feat: Handle direct Notion videos (#65)
enfycius pushed a commit to enfycius/docu-notion that referenced this issue Aug 20, 2023
enfycius pushed a commit to enfycius/docu-notion that referenced this issue Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants