API Rename FormField Value to getFormattedValue #1363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
emteknetnz
force-pushed
the
pulls/7.0/rename-ffv
branch
2 times, most recently
from
6aa1306 to
45794a1
Compare
emteknetnz
commented
Jan 24, 2025
| */ | ||
| public function getFormattedValue() | ||
| public function getFormattedValue(): ?DBField |
There was a problem hiding this comment.
While this method has the same name as FormField::getFormattedValue, it's a fundamentally different method
Putting strong typing on this is effectively unrelated refactoring
Note that the old docblock return type was wrong
emteknetnz
force-pushed
the
pulls/7.0/rename-ffv
branch
from
45794a1 to
6a92ece
Compare
emteknetnz
force-pushed
the
pulls/7.0/rename-ffv
branch
from
6a92ece to
60b96d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-framework#11468