Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plans for type hint / mypy support? #24

Open
besfahbod opened this issue Jul 8, 2019 · 4 comments
Open

Any plans for type hint / mypy support? #24

besfahbod opened this issue Jul 8, 2019 · 4 comments

Comments

@besfahbod
Copy link

Are there any plans for type hint / mypy support?

  1. OrderedSet is not a generic type, so it's not possible to use OrderedSet[str].
  2. An OrderedSet of strings is not considered compatible with typing.Set[str] or typing.Iterable[str], making it not sit well in type-hinted projects.
@Mattwmaster58
Copy link

Mattwmaster58 commented Apr 19, 2020

I believe it could be enough to augment this library with a typing stub (.pyi), but I'm not that experienced with the matter. I think this could also be a candidate for a type stubs in the typeshed library

@blumu
Copy link

blumu commented Aug 26, 2020

@Mattwmaster58 This project provides the typing stubs for the orderedset package: https://github.com/rominf/ordered-set-stubs. But somehow the project was archived claiming that the typing stubs are now part of orderedset itself, which does not appear to be the case. Any plan to include those stubs in the orderedset package in future releases?

@MapleCCC
Copy link

MapleCCC commented Mar 8, 2021

@blumu I think the type stub you mentioned is intended for https://github.com/LuminosoInsight/ordered-set , another ordered set implementation. Not this one.

@blumu
Copy link

blumu commented Mar 8, 2021

@MapleCCC You are right, my bad!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants