Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalise styles across plugins #27

Open
bedeoverend opened this issue Jun 1, 2017 · 2 comments
Open

Generalise styles across plugins #27

bedeoverend opened this issue Jun 1, 2017 · 2 comments
Assignees

Comments

@bedeoverend
Copy link
Contributor

Currently we've got a few different stylesheets being injected by plugins e.g. placeholder styles, pre-wrap styles. Plus there're also styles that should be applied to images, which is being done over on simpla-article but in reality should be done in this behavior.

All the plugins should be able to define styles that are (conditionally) applied, and all be injected into the one stylesheet. That stylesheet should also only be applied once per root to avoid unnecessary stylesheets.

@madeleineostoja
Copy link

That stylesheet should also only be applied once per root to avoid unnecessary stylesheets

FWIW that should be a future enhancement, shouldn't hold up implementation of this

@bedeoverend
Copy link
Contributor Author

Yup definitely 👍 can split it into a separate issue once core problem is resolved, if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants