Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safe Redirects #139

Open
acobster opened this issue Oct 14, 2020 · 0 comments
Open

Safe Redirects #139

acobster opened this issue Oct 14, 2020 · 0 comments

Comments

@acobster
Copy link
Contributor

Per lando sniff:

FILE: /app/lib/Conifer/Site.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 737 | WARNING | wp_redirect() found. Using wp_safe_redirect(), along
     |         | with the allowed_redirect_hosts filter if needed,
     |         | can help avoid any chances of malicious redirects
     |         | within code. It is also important to remember to
     |         | call exit() after a redirect so that no other
     |         | unwanted code is executed.
     |         | (WordPress.Security.SafeRedirect.wp_redirect_wp_redirect)
----------------------------------------------------------------------

This is relatively low-risk because it would require us to be running malicious code on the server already that uses the admin_url to make a malicious redirect. No sites are currently affected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant