Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Conifer\Twig\FormHelper filter names to better match Form API method names #96

Open
sdunham opened this issue Mar 29, 2019 · 0 comments
Assignees
Labels
documentation DOCUMENT ALL THE THINGS easy Should only take a few hours at most enhancement New feature or request

Comments

@sdunham
Copy link
Contributor

sdunham commented Mar 29, 2019

Expected behavior

Conifer's twig form filter functions should be a closer match to the corresponding class methods they call. And possibly be prefixed with something like form_ to avoid confusion and possible collisions with future custom twig filters. Docs should also reflect these updated filter names where appropriate.

Actual behavior

They aren't!

Steps to reproduce behavior

N/A

What version of WordPress/PHP/Timber/Conifer are you using?

Latest Conifer version & docs

How did you install Conifer? (for example, via git clone, GitHub zip download, Composer/Packagist?)

N/A

@sdunham sdunham added enhancement New feature or request documentation DOCUMENT ALL THE THINGS easy Should only take a few hours at most labels Mar 29, 2019
@sdunham sdunham self-assigned this Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation DOCUMENT ALL THE THINGS easy Should only take a few hours at most enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant