Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot choose Custom V-net and custom images in Azure #2910

Open
Kenadyi opened this issue Dec 27, 2023 · 8 comments · Fixed by #3362 · May be fixed by #4417
Open

Cannot choose Custom V-net and custom images in Azure #2910

Kenadyi opened this issue Dec 27, 2023 · 8 comments · Fixed by #3362 · May be fixed by #4417
Labels
clouds Cloud support and cloud-specifc features feature-request help wanted Extra attention is needed

Comments

@Kenadyi
Copy link

Kenadyi commented Dec 27, 2023 •
edited
Loading

I cannot choose Custom V-net and custom images in Azure, is there a specific format I have to use, or is the feature not available for Azure?

(sky) skypilot@kenadyinampudi:$ sky launch skypilot_azure.yaml
ValueError: Invalid config YAML (/home/skypilot/.sky/config.yaml): The following fields are invalid:
Found unsupported field 'azure'.
(sky) skypilot@kenadyinampudi:$ sky launch skypilot_azure.yaml
Task from YAML spec: skypilot_azure.yaml
ValueError: image_id is only supported for AWS/GCP/IBM/OCI, please explicitly specify the cloud.
(sky) skypilot@kenadyinampudi:~$
@concretevitamin concretevitamin added help wanted Extra attention is needed feature-request labels Dec 27, 2023
@Michaelvll
Copy link
Collaborator

Michaelvll commented Jan 11, 2024 •
edited
Loading

Thanks for raising the issue @Kenadyi!

It seems there are two major TODOs:

  • image_id support for Azure, like what we have for AWS/GCP.
  • Custom V-net (VPC) support for Azure, similar to what we support for AWS/GCP

@Michaelvll Michaelvll mentioned this issue Feb 5, 2024
Closed
@Michaelvll Michaelvll added the clouds Cloud support and cloud-specifc features label Feb 5, 2024
@concretevitamin
Copy link
Member

[ ] image_id support for Azure, like what we have for AWS/GCP.

Another user bumped this.

@cblmemo cblmemo mentioned this issue Mar 24, 2024
Merged
7 tasks
@concretevitamin
Copy link
Member

  • Custom V-net (VPC) support for Azure, similar to what we support for AWS/GCP

This seems still open.

@hsharifi7
Copy link

I have the same issue.

@github-actions GitHub Actions
Copy link

This issue is stale because it has been open 120 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Sep 15, 2024
@cblmemo cblmemo removed the Stale label Sep 15, 2024
@tomkukral
Copy link

tomkukral commented Nov 1, 2024 •
edited
Loading

Is there any progress on this? Can I help with implementing support for custom vnet in Azure?

@concretevitamin
Copy link
Member

@tomkukral would love your help on this! You could search for vpc_name in https://github.com/skypilot-org/skypilot/blob/master/sky/provision/aws/config.py and see how it's plumbed from ~/.sky/config.yaml to AWS SDK calls. This should be added similarly to https://github.com/skypilot-org/skypilot/tree/master/sky/provision/azure.

@tomkukral tomkukral linked a pull request Nov 26, 2024 that will close this issue
Open
5 tasks
@tomkukral
Copy link

tomkukral commented Nov 26, 2024 •
edited
Loading

I have created PR for this feature (#4417)

@concretevitamin can you check it and suggest changes or tests to be added?

tomkukral added a commit to tomkukral/skypilot that referenced this issue Dec 3, 2024
@tomkukral
azure: support for existing subnet and internal IPs
2b44133 
This change is adding possibility to configure azure.subnet_id

fixes skypilot-org#2910
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
clouds Cloud support and cloud-specifc features feature-request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
6 participants
@concretevitamin @tomkukral @Michaelvll @hsharifi7 @cblmemo @Kenadyi