Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Execute setup when --detach-setup and no run section #4430

Merged
merged 7 commits into from
Dec 3, 2024
Merged

[Core] Execute setup when --detach-setup and no run section #4430

merged 7 commits into from
Dec 3, 2024
+112 −76

Conversation

Michaelvll
Copy link
Collaborator

@Michaelvll Michaelvll commented Dec 3, 2024 •
edited
Loading

Fixes #4419

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
    • sky launch -c test-setup -s test.yaml 
      resources:
  cloud: aws
  cpus: 2+
  region: us-east-1

setup: hostname
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh

cblmemo
cblmemo reviewed Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@cblmemo cblmemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Michaelvll ! Mostly LGTM. Left a discussion

sky/backends/cloud_vm_ray_backend.py Show resolved Hide resolved
sky/backends/cloud_vm_ray_backend.py Outdated Show resolved Hide resolved
cblmemo
cblmemo approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@cblmemo cblmemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the elaboration! LGTM.

Merged via the queue into master with commit c3c1fde Dec 3, 2024
19 checks passed
@Michaelvll Michaelvll deleted the execute-setup-when-detached branch December 3, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cblmemo cblmemo cblmemo approved these changes

@yika-luo yika-luo Awaiting requested review from yika-luo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Core] setup will not run if you don't have a run section and --detach-setup is specified
3 participants
@Michaelvll @cblmemo @yika-luo