Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] setup will not run if you don't have a run section and --detach-setup is specified #4419

Closed
yika-luo opened this issue Nov 26, 2024 · 1 comment · Fixed by #4430
Closed

[Core] setup will not run if you don't have a run section and --detach-setup is specified #4419

yika-luo opened this issue Nov 26, 2024 · 1 comment · Fixed by #4430
Labels
P0

Comments

@yika-luo
Copy link
Collaborator

Version & Commit info:

  • sky -v: PLEASE_FILL_IN
  • sky -c: PLEASE_FILL_IN
@Michaelvll Michaelvll changed the title setup will not run if you don't have a run section [Core] setup will not run if you don't have a run section and --detach-setup is specified Nov 26, 2024
@Michaelvll
Copy link
Collaborator

To reproduce:

# test.yaml
setup: hostname

sky launch -c test-detach --detach-setup test.yaml

The setup is not executed, due to:

skypilot/sky/backends/cloud_vm_ray_backend.py

Lines 3463 to 3465 in 23f9821

if task.run is None:
logger.info('Run commands not specified or empty.')
return None

@Michaelvll Michaelvll mentioned this issue Dec 3, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Core] Execute setup when --detach-setup and no run section skypilot-org/skypilot
2 participants
@Michaelvll @yika-luo