-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Serve] Enable multiple ports in SkyServe replicas #4356
base: master
Are you sure you want to change the base?
Conversation
Hi @cblmemo ! Would you like to have a look at this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this feature @Conless ! Mostly LGTM. Left a discussion.
Also we might want to update related documents for this :))
Can we also update the PR description? |
Also, it will be great if we can test on some real world usage (e.g. deploy an LLM service and expose metric port in vLLM or dashboard in ray |
Current implementation of SkyServe only allows the replicas to expose one port. In some cases, services may need to expose multiple ports for custom controller, GUI interface, etc. This PR adds support for it by allowing multiple ports, but requiring user to specify one as the main port in the service section, if multiple ports are provided.
The output of
sky serve status
will look like:while the other ports (8001, 3000) are still accessible.
Tested (run the relevant ones):
bash format.sh
sky serve up
,sky serve status
and accessing the service with config:pytest tests/test_smoke.py
pytest tests/test_smoke.py::test_fill_in_the_name
conda deactivate; bash -i tests/backward_compatibility_tests.sh