SlChangeEvent with unknown type

[adamPrzybyszExt]

Provide a general summary of the issue here

sl-change /slChange event throws mismatch types error. I don't see any possibility to omit this (except using $any; maybe I miss something) but (slChange)="onChange($event.detail)" nor (slChange)="onChange($event)" won't help. In component's method we expect boolean, not unknown.

🤔 Expected Behavior?

No mismatch types error using any events: change, select etc.

😯 Current Behavior

Throws error on valid code.

💁 Possible Solution

• Change event value type to any.
• Make more precise event value e.g. boolean for checkbox.

🖥️ Steps to Reproduce

1. Add sl-checkbox to template
2. Bind sl-checkbox event with method in component.
3. In method: expect CustomEvent<boolean> or boolean.

What browsers are you seeing the problem on? (only for bugs in code)

Chrome

If other, please specify.

No response

What operating system are you using?

Windows 10

👤 Your name

Adam Przybysz

🧢 Your product/team

ETSL

🎨 Your Theme(s)

Editorial Suite

[jpzwarte]

@adamPrzybyszExt It's unclear exactly what typing error you're running into. Can you provide more code?

[adamPrzybyszExt]

[adamPrzybyszExt]

[jpzwarte]

What about just passing $event and doing onChange(event: SlChangeEvent<boolean>) ?

[jpzwarte]

The "problem" here is that the SlChangeEvent is not checkbox specific. And even then, the value of a checkbox may be something other than a boolean.

[adamPrzybyszExt]

The same situation. Btw SlChangeEvent is not exported in shared/index.d.ts

[jpzwarte]

The same situation. Btw SlChangeEvent is not exported in shared/index.d.ts

It's exported from @sl-design-system/shared/events.js.

[jpzwarte]

I think your most practical solution would then be to do $event as SlChangeEvent<boolean>?

I don't see how this can be fixed, since Checkbox has a generic type for the value.

[adamPrzybyszExt]

In our situation the only workaround is using $any() in template but imagine how many of these will be needed in our app. Why don't just change unknown to any?

[jpzwarte]

Yeah, perhaps that is better. I'll have a look at that option.