convert colors from 0..255 scale to 0..1

Per the LÖVE 11.0 changelog:

> Changed all color values to be in the range 0-1, rather than 0-255.

All internal color values have been updated, which largely means that they are now divided by 255.

 In a future commit, it may be worth using decimal approximations to tidy up the code, as the `/255`s are rather unsightly. However, this would technically lead to the colors of some objects being ever so slightly changed. To avoid potentially undesirable behavior, the only legacy numbers to be replaced with decimals are 127 (0.5), 128 (0.5), and 255 (1.0). Instances of 127 which may have caused issues with community content were left intact as `127/255`.

 This commit also fixes some miscellaneous issues, namely sounds using `.isPlaying()` instead of `:isPlaying`.

 Known regressions:
 - Configs from older versions of the game which used 0..255 colors are not yet automatically updated.
 - When exiting the pause menu, the music plays from the beginning instead of resuming.
 - Custom character colors cannot be modified in the settings.

Author: qixils

andgate.lua

@@ -50,7 +50,7 @@ end
 
 function andgate:draw()
 	if self.visible then
-		love.graphics.setColor(255, 255, 255)
+		love.graphics.setColor(1, 1, 1)
 		love.graphics.draw(gateimg, gatequad[9], math.floor((self.x-1-xscroll)*16*scale), ((self.y-1-yscroll)*16-8)*scale, 0, scale, scale)
 		--love.graphics.draw(andgateimg, math.floor((self.x-1-xscroll)*16*scale), ((self.y-yscroll-1)*16-8)*scale, 0, scale, scale)
 	end
@@ -88,4 +88,4 @@ function andgate:input(t, input)
 			self.outputstate = pass
 		end
 	end
-end
+end

android.lua

@@ -93,8 +93,8 @@ function androidLoad()
 	buttons["portal1"].portal = true
 	buttons["portal2"] = touchButton:new("r", "2", t["portal2"][1],t["portal2"][2],t["portal2"][3],t["portal2"][4], "round")
 	buttons["portal2"].portal = true
-	buttons["portal1"].color = {60, 188, 252}
-	buttons["portal2"].color = {232, 130, 30}
+	buttons["portal1"].color = {60/255, 188/255, 252/255}
+	buttons["portal2"].color = {232/255, 130/255, 30/255}
 
 	-- shift keys to left
 	if fourbythree then
@@ -216,7 +216,7 @@ function androidDraw()
 			local x, y, w, h = skin["center"][1]:getViewport()
 			skinSpriteBatch:add(skin["center"][1], skinData["center"][1], skinData["center"][2], 0, skinData["center"][3]/w, skinData["center"][4]/h)
 		end
-		love.graphics.setColor(255,255,255)
+		love.graphics.setColor(1,1,1)
 		love.graphics.draw(skinSpriteBatch,0,0)
 		for name, b in pairs(buttons) do
 			if skinData.highlightonpress or not b.held then
@@ -231,12 +231,12 @@ function androidDraw()
 	end
 
 	--[[touch debug
-	love.graphics.setColor(255,0,0)
+	love.graphics.setColor(1,0,0)
 	local mx,my= androidGetCoords(mouseTouchX,mouseTouchY)
 	love.graphics.circle("fill",mx,my,2)
-	love.graphics.setColor(255,255,0)
+	love.graphics.setColor(1,1,0)
 	love.graphics.circle("fill",lastTouchX,lastTouchY,1)
-	love.graphics.setColor(0,255,255)
+	love.graphics.setColor(0,1,1)
 	love.graphics.circle("fill",lastReleaseX,lastReleaseY,1)]]
 
 	if not androidLowRes then

androidbutton.lua

@@ -64,27 +64,27 @@ function touchButton:draw(spriteBatch, quad)
 				love.graphics.setLineWidth(1)
 			end
 			if self.held then
-				love.graphics.setColor(100, 100, 100, 140)
+				love.graphics.setColor(100/255, 100/255, 100/255, 140/255)
 			elseif highlight then
-				love.graphics.setColor(90, 90, 90, 140)
+				love.graphics.setColor(90/255, 90/255, 90/255, 140/255)
 			elseif self.color then
-				love.graphics.setColor(self.color[1], self.color[2], self.color[3], 80)
+				love.graphics.setColor(self.color[1], self.color[2], self.color[3], 80/255)
 			else
-				love.graphics.setColor(30, 30, 30, 80)
+				love.graphics.setColor(30/255, 30/255, 30/255, 80/255)
 			end
 			if self.round then
 				local x, y, r = self.x+self.w/2, self.y+self.h/2,self.r
 				love.graphics.circle("fill", x, y, r, 8)
-				love.graphics.setColor(255, 255, 255, 140)
+				love.graphics.setColor(1, 1, 1, 140/255)
 				love.graphics.circle("line", x, y, r, 8)
 			else
 				local x, y, w, h = self.x, self.y, self.w, self.h
 				love.graphics.rectangle("fill", x, y, w, h)
-				love.graphics.setColor(255, 255, 255, 140)
+				love.graphics.setColor(1, 1, 1, 140/255)
 				love.graphics.rectangle("line", x+.5, y+.5, w, h)
 			end
 
-			love.graphics.setColor(255, 255, 255)
+			love.graphics.setColor(1, 1, 1)
 			if self.text then
 				properprintfast(self.text, math.floor(self.x+self.w/2-string.len(self.text)*4), math.floor(self.y+self.h/2-4))
 			elseif self.img then

animation.lua

@@ -52,13 +52,13 @@ disableanimation					disables this animation from triggering
 enableanimation						enables this animation to trigger
 playerjump[:player]					makes players jump (as high as possible)
 playerstopjump[:player]				makes players abort the jump (for small jumps)
-dialogbox:text[:speaker]			creates a dialogbox with <text> and <speaker>
+dialogbox:text[:speaker][:color]	creates a dialogbox with <text> and <speaker> and <color> (from textcolors in variables.lua)
 removedialogbox						removes the dialogbox
 playmusic:i							plays music <i>
 screenshake:power					makes the screen shake with <power>
 addcoins:coins						adds <coins> coins
 addpoints:points					adds <points> points
-changebackgroundcolor:r:g:b			changes background color ro rgb
+changebackgroundcolor:r:g:b			changes background color to rgb
 killplayer[:player]					hurts player(s)
 changetime:time						changes the time left to <time>
 loadlevel:world:level:sublevel:exit	starts level <world>-<level>_<sublevel> pipeexitid:<exit>
@@ -592,7 +592,7 @@ function animation:update(dt)
 					playmusic()
 				end
 			elseif v[1] == "changebackgroundcolor" then
-				love.graphics.setBackgroundColor(tonumber(v[2]) or 255, tonumber(v[3]) or 255, tonumber(v[4]) or 255)
+				love.graphics.setBackgroundColor((tonumber(v[2]) or 255)/255, (tonumber(v[3]) or 255)/255, (tonumber(v[4]) or 255)/255)
 			elseif v[1] == "killplayer" then
 				if v[2] == "everyone" then
 					for i = 1, players do

animationguiline.lua

@@ -1841,13 +1841,13 @@ function animationguiline:init(tabl, t2)
 	local firstwidth = 22--#animationstrings[self.type][start]
 
 	self.deletebutton = guielement:new("button", 0, 0, "x", function() self:delete() end, nil, nil, nil, 8, 0.1)
-	self.deletebutton.textcolor = {200, 0, 0}
+	self.deletebutton.textcolor = {200/255, 0, 0}
 
 	self.downbutton = guielement:new("button", 0, 0, "↓", function() self:movedown() end, nil, nil, nil, 8, 0.1)
-	self.downbutton.textcolor = {255, 255, 255}
+	self.downbutton.textcolor = {1, 1, 1}
 
 	self.upbutton = guielement:new("button", 0, 0, "↑", function() self:moveup() end, nil, nil, nil, 8, 0.1)
-	self.upbutton.textcolor = {255, 255, 255}
+	self.upbutton.textcolor = {1, 1, 1}
 
 	self.elements[1].gui = guielement:new("dropdown", 0, 0, firstwidth, function(val) self:changemainthing(val) end, start, unpack(animationstrings[self.type]))
 	self.elements[1].width = 14+firstwidth*8
@@ -2048,7 +2048,7 @@ end
 function animationguiline:draw(x, y)
 	love.graphics.setColor(0, 0, 0)
 	love.graphics.rectangle("fill", x*scale, y*scale, (width*16-x)*scale, 11*scale)
-	love.graphics.setColor(255, 255, 255)
+	love.graphics.setColor(1, 1, 1)
 
 	local xadd = 0
 	self.deletebutton.x = x+xadd
@@ -2068,7 +2068,7 @@ function animationguiline:draw(x, y)
 
 	for i = 1, #self.elements do
 		if self.elements[i].t == "text" then
-			love.graphics.setColor(255, 255, 255)
+			love.graphics.setColor(1, 1, 1)
 			properprintF(self.elements[i].value, (x+xadd-1)*scale, (y+2)*scale)
 			xadd = xadd + self.elements[i].width
 		else

belt.lua

@@ -205,9 +205,9 @@ function drawbelt(x, y, length, i, color) --for editor
 		img = beltonimg
 		row = tonumber(color) or 1
 	end
-	local x, y = x-1, y-1
-	local length = math.min(99, math.max(2, math.floor(tonumber(length or 3))))
-	love.graphics.setColor(255, 255, 255)
+	x, y = x-1, y-1
+	length = math.min(99, math.max(2, math.floor(tonumber(length or 3))))
+	love.graphics.setColor(1, 1, 1)
 	love.graphics.draw(img, beltquad[row][1], math.floor((x-xscroll)*16*scale), math.floor((y-yscroll-.5)*16*scale), 0, scale, scale)
 	for i = 1, length-2 do
 		love.graphics.draw(img, beltquad[row][2], math.floor((x+i-xscroll)*16*scale), math.floor((y-yscroll-.5)*16*scale), 0, scale, scale)
@@ -292,4 +292,4 @@ function belt:floorcollide(a, b)
 end
 
 function belt:passivecollide(a, b)
-end
+end

blocktogglebutton.lua

@@ -184,7 +184,7 @@ end
 
 function blocktogglebutton:draw()
 	if not self.drawable then
-		love.graphics.setColor(255, 255, 255)
+		love.graphics.setColor(1, 1, 1)
 		love.graphics.draw(self.graphic, self.quad, math.floor(((self.x-xscroll)*16+self.offsetX)*scale), math.floor(((self.y-yscroll)*16-self.offsetY)*scale), self.rotation, scale, scale, self.quadcenterX, self.quadcenterY)
 	end
 end
@@ -453,7 +453,7 @@ function buttonblock:init(x, y, color, solid)
 end
 
 function buttonblock:draw()
-	--love.graphics.setColor(255, 255, 255)
+	--love.graphics.setColor(1, 1, 1)
 	love.graphics.draw(self.graphic, self.quad, math.floor(((self.x-xscroll)*16+self.offsetX)*scale), math.floor(((self.y-yscroll)*16-self.offsetY)*scale), 0, scale, scale, self.quadcenterX, self.quadcenterY)
 end
 
@@ -486,4 +486,4 @@ end
 
 function buttonblock:floorcollide(a, b)
 
-end
+end

cappy.lua

@@ -200,7 +200,7 @@ function cappy:draw()
 		if self.hat == 1 then
 			love.graphics.setColor(self.player.colors[1])
 		else
-			love.graphics.setColor(255, 255, 255)
+			love.graphics.setColor(1, 1, 1)
 		end
 		local graphic = hat[self.hat].graphic
 		local quad = hat[self.hat].quad[1]
@@ -401,4 +401,4 @@ function cappy:globalcollide(a, b)
 		end]]
 	end
 	return true
-end
+end

characters.lua

@@ -1,8 +1,31 @@
 --I have no idea what i'm even doing
+local colorvariables = {"colors", "defaultcolors", "starcolors", "flowercolor", "hammersuitcolor", "frogsuitcolor", "leafcolor", "iceflowercolor", "tanookisuitcolor", "statuecolor", "superballcolor", "blueshellcolor", "boomerangcolor"}
 local animfiles = {"", "big", "fire", "ice", "superball", "hammer", "frog", "raccoon", "tiny", "tanooki", "skinny", "cape", "shell", "boomerang"}
 local blankimg = love.graphics.newImage(love.image.newImageData(1, 1))
 local splitimage
 
+local function iscolorvariable(key)
+	for i, v in ipairs(colorvariables) do
+		if v == key then
+			return true
+		end
+	end
+	return false
+end
+
+local function convertcolors(table)
+	if table == nil or #table == 0 then
+		return
+	end
+	for i, v in ipairs(table) do
+		if type(v) == "table" then
+			convertcolors(v)
+		else
+			table[i] = tonumber(v)/255
+		end
+	end
+end
+
 function loadcustomplayers()
 	characters = {list = {}, data = {}}
 	local dir = love.filesystem.getDirectoryItems("alesans_entities/characters")
@@ -24,6 +47,8 @@ function loadcustomplayers()
 				i = #characters["list"]+1,
 
 				--colors
+				-- !! MAKE SURE to add any new RGB variables to `colorvariables` at the top !!
+				-- !! to ensure they get automatically converted from 0..255 to 0..1        !!
 				colorables = {"hat", "hair", "skin"},
 				colors = {},
 				defaultcolors = false,
@@ -347,6 +372,11 @@ function loadcustomplayers()
 					temp = err
 					--works! so set properties
 					for i, v in pairs(temp) do
+						-- convert numbers to 0..1
+						if iscolorvariable(i) then
+							convertcolors(v)
+						end
+						-- set properties
 						playerstuff[i] = v
 						if i == "health" or i == "fireenemy" then
 							playerstuff["advanced"] = true
@@ -422,6 +452,7 @@ function loadcustomplayers()
 end
 
 --local splitShader
+--`color` param is expected to be an array of 0..255 values (r, g, b) to maintain support for old community-created content
 function splitimage(img, color, exclude, imagedata) --split singe image into colorable images
 	if false then --useShader then
 		if not splitShader then
@@ -468,25 +499,26 @@ function splitimage(img, color, exclude, imagedata) --split singe image into col
 		for x = 0, input:getWidth()-1 do
 			for y = 0, input:getHeight()-1 do
 				local r, g, b, a = input:getPixel(x, y)
+				local rr, rg, rb = round(r*255), round(g*255), round(b*255)
 				local place = false
 				if exclude then
 					place = true
 					for i, c in pairs(color) do
-						if r == c[1] and g == c[2] and b == c[3] then
+						if rr == c[1] and rg == c[2] and rb == c[3] then
 							place = false
 							break
 						end
 					end
 				else
-					if r == color[1] and g == color[2] and b == color[3] then
+					if rr == color[1] and rg == color[2] and rb == color[3] then
 						place = true
 					end
 				end
 				if place then
 					if exclude then
 						output:setPixel(x, y, r, g, b, a)
 					else
-						output:setPixel(x, y, 255, 255, 255, a)
+						output:setPixel(x, y, 1, 1, 1, a)
 					end
 				end
 			end
@@ -618,4 +650,4 @@ end
 --[[function getplayer() --sets abilities and sprites
 	playerstuff = { playername, jumpheight, speed, grip(friction)}
 	playerabilities = {raccoon}
-end]]
+end]]

checkpointflag.lua

@@ -9,7 +9,7 @@ function checkpointflag:init(x, y, r, i)
 	self.r = r
 	self.i = i
 	self.color = {0,0,0}
-	self.symbolcolor = {255,255,255}
+	self.symbolcolor = {1,1,1}
 	self.activatetimer = false
 
 	local v = convertr(r[3], {"string", "num"}, true)
@@ -99,7 +99,7 @@ function checkpointflag:draw(drop)
 		end
 	end
 	if not drop then
-		love.graphics.setColor(255, 255, 255)
+		love.graphics.setColor(1, 1, 1)
 	end
 	love.graphics.draw(checkpointflagimg, checkpointflagquad[spriteset][quadi], math.floor(((self.x+self.width/2-xscroll)*16+offx)*scale), math.floor(((self.y+self.height/2-yscroll-.5)*16+offy)*scale), self.rotation, scale, scale, 16, 16)
 end
@@ -159,4 +159,4 @@ function checkpointflag:activate(playeri)
 	if (self.color[1]+self.color[2]+self.color[3])/3 > 200 then --is the color bright? if so, use a black symbol
 		self.symbolcolor = {0, 0, 0}
 	end
-end
+end