Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential breaking changes #410

Open
AnnMarieW opened this issue Nov 12, 2024 · 2 comments
Open

Potential breaking changes #410

AnnMarieW opened this issue Nov 12, 2024 · 2 comments

Comments

@AnnMarieW
Copy link
Collaborator

In line with our roadmap, we’re committed to minimizing breaking changes. However, I wanted to open a discussion about potential breaking changes that may come up.

DatePicker Component

Currently, the DatePicker in DMC corresponds to the DatePickerInput component from Mantine. Mantine also includes a stand-alone DatePicker that functions solely as a calendar, separate from the input dropdown. There was a request and a strong use case shared on Discord for adding this stand-alone DatePicker.

To avoid a breaking change, should we consider naming the new stand-alone DatePicker something else? On the other hand, to keep DMC aligned with the upstream Mantine library, it might be better to rename the existing DatePicker to DatePickerInput.

@martindemker
Copy link

The standalone DatePicker does have valid uses cases, so it would be great to add it to DMC. I recently also stumbled over this and was confused why the naming is not consistent between DMC and Mantine. I would prefer a breaking change in DMC to keep alignment with Mantine, since the necessary code adjustment for users would be a simple search and replace.

@AnnMarieW
Copy link
Collaborator Author

Update
By popular demand, the DatePicker will be renamed to DatePickerInput in the next release. 0.15.0. For more info see Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants