Adding chromPeaks metadata to the Spectra output of chromPeakSpectra()

[philouail]

@jorainer Just wanted to get your opinion on this.. Because appending multiple column at once to the spectraData() of an object is not possible. i only see 2 options:

• accessing and manipulating the spectraData slot ( in this PR)
• a for loop adding columns one by ones to the res object.

Am I missing an easier way to deal with this ?

This PR is not ready, just wanted to get your opinion before I also update featureSpectra() and the documentation.

[jorainer]

this will be a very useful and helpful addition Phili! thanks! but there are some more general thing we can/should discuss

[philouail]

@jorainer do you know what's happening with the Linux checks ? i get a weird error, did I do something wrong ?

[jorainer]

Looks good to me, thanks Phili! Only thing is that I find the parameter names a bit bulky - addColumnsChromPeaks and addColumnsFeatures - I would prefer either chromPeakColumn/featureColumns or addChromPeakColumns/addFeatureColumns.

Also, I think you were right with the prefix. Maybe we don't expose that parameter in the function - I would still use it internally, so we can re-add it as a function parameter if needed, but for now I would remove it from the function definition.

[jorainer]

Thanks for adapting, but now I found some additional issues that might cause problems later, i.e. it would be key to check that the requested columns are available. sorry that I missed that the previous time.

[jorainer]

Thanks Phili! Looks great! Only very minor thing: please bump the version to 4.5.2.

@sneumann , would be OK for me to merge into devel and push to BioC

[sneumann]

looks great, merging and pushing now. Yours, Steffen