SNOW-1553756 use forked version 99design/keyring without kwallet/secretservice to avoid dbus issue

[sfc-gh-dszmolka]

#1183 for the full story

• use forked keyring from Using keyring on Linux leaves dbus-daemons running, perhaps because godbus connection is not closed 99designs/keyring#103 (comment) which eliminates Linux kwallet/secretservice, which we don't use anyways but causes headache with dbus upon keyring init()

Description

99designs/keyring has a long outstanding bug (99designs/keyring#103) which on certain Linux distros, results in runaway dbus-daemon processes. It seems to originate from kwallet/secretservice modules of the said library, which we in gosnowflake do not even use; we use a JSON file for temporal credential storage on Linux.

Yet, suffering from the issue originating from the bug, because the modules are of course initialized (= bug happens) even when not used.

A long term and nice solution will be entirely replacing 99design/keyring with a different implementation, but given the priorities so far and the foreseeable near future, it's not realistic to expect it will happen very soon.

Thus: workaround; use a fork of keyring as many other people to, which simply nukes kwallet and secretservice where the bug is coming from. 👌

Checklist

• Created tests which fail without the change (if possible)
• Extended the README / documentation, if necessary

[sfc-gh-pfus]

Why using replace? It was required in hashicorp, because it was a transitive dependency for them (their direct dependency was gosnowflake). For us it is a direct dependency, so we can use it directly.

[sfc-gh-dszmolka]

hmm did not consider it but you're right, lets fix that

[sfc-gh-dszmolka]

as we discussed: since the fork declares itself as 99design/keyring, cannot import it directly due to

go: github.com/snowflakedb/gosnowflake imports
        github.com/99designs/keyring: github.com/Jeffail/[email protected]: parsing go.mod:
        module declares its path as: github.com/99designs/keyring
                but was required as: github.com/Jeffail/keyring

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.27%. Comparing base (e5ae90f) to head (dc2ad03).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1296      +/-   ##
==========================================
- Coverage   82.30%   82.27%   -0.03%     
==========================================
  Files          55       55              
  Lines       13600    13600              
==========================================
- Hits        11193    11190       -3     
- Misses       2407     2410       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.