Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output Assignment Uses <-- Without Constraints, Allowing Malicious Proof Generation #3

Open
Koukyosyumei opened this issue Feb 17, 2025 · 0 comments

Comments

@Koukyosyumei
Copy link

Koukyosyumei commented Feb 17, 2025

In zkPhoto.circom, the output is assigned using the <-- operator, which does not enforce any constraints. As a result, a malicious prover can generate a fake proof with incorrect outputs, compromising the integrity of the circuit.

out[idx] <--

Without explicit constraints enforcing the expected behavior of the shift operation, the circuit becomes vulnerable to manipulation. A prover could arbitrarily choose an output without satisfying any underlying computation.

To properly implement the shift operation with sufficient constraints, consider referencing established implementations for similar functionalities, such as:

Would appreciate any thoughts or confirmation on this fix!

@Koukyosyumei Koukyosyumei changed the title Under-Constrained Problem in zkPhoto template Output Assignment Uses <-- Without Constraints, Allowing Malicious Proof Generation Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant