From 6d34607536f638a8f2ed49af8e42838b5fe24658 Mon Sep 17 00:00:00 2001
From: Riccardo Piccoli <riccardo.piccoli@gmail.com>
Date: Mon, 27 Jul 2020 18:50:15 +0200
Subject: [PATCH] improve logging

---
 cmd/node-policy-webhook/node-policy-webhook.go | 5 +----
 pkg/admission/reviewer.go                      | 2 +-
 pkg/http/handler.go                            | 1 -
 3 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/cmd/node-policy-webhook/node-policy-webhook.go b/cmd/node-policy-webhook/node-policy-webhook.go
index 6174991..2e0a2b2 100644
--- a/cmd/node-policy-webhook/node-policy-webhook.go
+++ b/cmd/node-policy-webhook/node-policy-webhook.go
@@ -28,8 +28,6 @@ const DEFAULT_BIND_ADDRESS = ":8443"
 var handler *h.HttpHandler
 
 func init() {
-	klog.V(0).Infof("Starting node-policy-webhook")
-
 	handler = getHttpHandler()
 }
 
@@ -56,7 +54,6 @@ func main() {
 	rootCmd.MarkFlagRequired("tls-cert")
 	rootCmd.MarkFlagRequired("tls-key")
 
-	klog.V(0).Infof("Command initialised")
 	if err := rootCmd.Execute(); err != nil {
 		fmt.Fprintln(os.Stderr, err)
 		os.Exit(1)
@@ -92,7 +89,7 @@ func run(params *params) {
 	if address == "" {
 		address = DEFAULT_BIND_ADDRESS
 	}
-	klog.V(0).Infof("Starting server, bund at %v", address)
+	klog.V(0).Infof("Starting server, bound at %v", address)
 	klog.Infof("Listening to address %v", address)
 	srv := &http.Server{
 		Addr:         address,
diff --git a/pkg/admission/reviewer.go b/pkg/admission/reviewer.go
index df8a2c4..f07f958 100644
--- a/pkg/admission/reviewer.go
+++ b/pkg/admission/reviewer.go
@@ -80,7 +80,7 @@ func (r *AdmissionReviewer) newAdmissionError(pod *v1.Pod, err error) *v1beta1.A
 }
 
 func (r *AdmissionReviewer) admissionAllowedResponse(pod *v1.Pod) *v1beta1.AdmissionResponse {
-	klog.V(log.EXTENDED).Infof("Skipping admission review for pod %s/%s", pod.Namespace, pod.Name)
+	klog.Errorf("Skipping admission review for pod %s/%s", pod.Namespace, pod.Name)
 	return &v1beta1.AdmissionResponse{
 		Allowed: true,
 	}
diff --git a/pkg/http/handler.go b/pkg/http/handler.go
index 6e150c1..98c28ac 100644
--- a/pkg/http/handler.go
+++ b/pkg/http/handler.go
@@ -21,7 +21,6 @@ func NewHttpHanlder(reviewer *admission.AdmissionReviewer) *HttpHandler {
 }
 
 func (h *HttpHandler) HealthCheckHandler(w http.ResponseWriter, r *http.Request) {
-	klog.Warning("Responding HC")
 	w.WriteHeader(http.StatusOK)
 	if _, err := w.Write([]byte("ok")); err != nil {
 		failIfError(w, err)