enhance(server): boolean paused property parsing

Author: xeruf

.dev/githooks/commit-msg

@@ -5,7 +5,7 @@ scopes_file=".dev/scopes.txt"
 test -r $scopes_file &&
   scopes="($(cat "$scopes_file" | sed '/^\(#.*\|\)$/d' | sed ':a;N;s/\n/|/g;ta'))"
 
-head -1 "$1" | grep -Eq "^(fix|feat|docs|style|refactor|test|build|rework|release|revert)(\(${scopes:-.*}(/.+)?\))?: [A-Za-z]"
+head -1 "$1" | grep -Eq "^(fix|feat|enhance|docs|style|refactor|test|build|rework|release|revert)(\(${scopes:-.*}(/.+)?\))?: [A-Za-z]"
 result=$?
 if test $result -ne 0
 then printf "Invalid commit message: '$(head -1 "$1")'

.dev/githooks/prepare-commit-msg

@@ -39,11 +39,11 @@ then
       printf "feat(dev): "
     # Example for gradle projects
     expr "$path" : "gradle" \| "$path" : "build" >/dev/null &&
-      printf "chore(gradle): "
+      printf "build(gradle): "
 
     printf "\n\n# Please enter the message in the format\n"
     echo "# <type>(<scope>): <description>"
-    echo "# Possible types: fix, feat, docs, style, refactor, test, build"
+    echo "# Possible types: fix, feat, enhance, docs, style, refactor, test, build"
     test -n "$scopes" && echo "# Allowed scopes: $scopes"
     echo "# For details see https://www.notion.so/softwarechallenge/Git-217333329ea64db5b2cc8bbbaf79db87"
     echo "$original"

server/src/main/java/sc/server/Configuration.java

@@ -48,8 +48,8 @@ public static void loadServerProperties() {
     } else {
       logger.warn("Could not find server.properties at {}, will use default values!", file);
     }
+    // Defaults, only if server.properties cannot be loaded
     properties.setProperty(PASSWORD_KEY, "examplepassword");
-    properties.setProperty(PAUSED, "false");
   }
 
   public static void load(Reader reader) throws IOException {
@@ -113,12 +113,12 @@ public static <T> T get(String key, Class<T> type, T defaultValue) {
   }
 
   private static boolean toBoolean(String value) {
-    if ("true".equals(value)) {
+    if ("true".equalsIgnoreCase(value)) {
       return true;
-    } else if ("false".equals(value)) {
+    } else if ("false".equalsIgnoreCase(value)) {
       return false;
     } else {
-      throw new IllegalArgumentException("Argument must be true or false");
+      throw new IllegalArgumentException("Argument '" + value + "' should be true or false");
     }
   }
 

server/src/main/java/sc/server/gaming/GameRoomManager.java

@@ -73,7 +73,7 @@ public GameRoom createGameRoom(IGameInstance game, boolean prepared) {
     GameRoom room = new GameRoom(generateRoomId(), this, game);
     // pause room on JoinRoomRequest if specified in server.properties
     if (!prepared) {
-      boolean paused = Boolean.parseBoolean(Configuration.get(Configuration.PAUSED));
+      boolean paused = Configuration.get(Configuration.PAUSED, Boolean.class, false);
       room.pause(paused);
     }