Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[solvcon] find a way to resolve numpy support of extra_c_compile_args in build_ext.py #103

Open
tai271828 opened this issue Jan 30, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@tai271828
Copy link
Collaborator

When working on #98 , we realized that the latest numpy seems to change its distribution approach so
numpy/distutils/command/build_ext.py does not support
extra_c_compile_argsin the way we expected to cause the following error:

    /usr/lib/python3.8/site-packages/numpy/distutils/command/build_ext.py", line 380,
    in build_extension extra_cflags = ext.extra_c_compile_args or [] AttributeError:
    'Extension' object has no attribute 'extra_c_compile_args'
    make: *** [Makefile:84: legacy] Error 1                                           

We need to find a way to resolve this issue so the whole SOLVCON build stack could enjoy the latest numpy in the end.

@tai271828 tai271828 self-assigned this Jan 30, 2022
tai271828 added a commit to tai271828/devenv that referenced this issue Jan 30, 2022
The latest numpy seems to change its distribution approach so
numpy/distutils/command/build_ext.py does not support
extra_c_compile_argsin the way we expected to cause the following error:

    /usr/lib/python3.8/site-packages/numpy/distutils/command/build_ext.py", line 380,
    in build_extension extra_cflags = ext.extra_c_compile_args or [] AttributeError:
    'Extension' object has no attribute 'extra_c_compile_args'
    make: *** [Makefile:84: legacy] Error 1

Let us keep using numpy 1.21.4 until we fix this issue.

Issue: solvcon#98 solvcon#103
@yungyuc yungyuc added the bug Something isn't working label Jan 30, 2022
tai271828 added a commit to tai271828/devenv that referenced this issue Jan 30, 2022
The latest numpy seems to change its distribution approach so
numpy/distutils/command/build_ext.py does not support
extra_c_compile_argsin the way we expected to cause the following error:

    /usr/lib/python3.8/site-packages/numpy/distutils/command/build_ext.py", line 380,
    in build_extension extra_cflags = ext.extra_c_compile_args or [] AttributeError:
    'Extension' object has no attribute 'extra_c_compile_args'
    make: *** [Makefile:84: legacy] Error 1

Let us keep using numpy 1.21.4 until we fix this issue.

Issue: solvcon#98 solvcon#103
tai271828 added a commit to tai271828/devenv that referenced this issue Jan 30, 2022
The latest numpy seems to change its distribution approach so
numpy/distutils/command/build_ext.py does not support
extra_c_compile_argsin the way we expected to cause the following error:

    /usr/lib/python3.8/site-packages/numpy/distutils/command/build_ext.py", line 380,
    in build_extension extra_cflags = ext.extra_c_compile_args or [] AttributeError:
    'Extension' object has no attribute 'extra_c_compile_args'
    make: *** [Makefile:84: legacy] Error 1

Let us keep using numpy 1.21.4 until we fix this issue.

Issue: solvcon#98 solvcon#103
tai271828 added a commit to tai271828/devenv that referenced this issue Jan 30, 2022
The latest numpy seems to change its distribution approach so
numpy/distutils/command/build_ext.py does not support
extra_c_compile_argsin the way we expected to cause the following error:

    /usr/lib/python3.8/site-packages/numpy/distutils/command/build_ext.py", line 380,
    in build_extension extra_cflags = ext.extra_c_compile_args or [] AttributeError:
    'Extension' object has no attribute 'extra_c_compile_args'
    make: *** [Makefile:84: legacy] Error 1

Let us keep using numpy 1.21.4 until we fix this issue.

Issue: solvcon#98 solvcon#103
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants