Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make target is recreating deb packages even though they are present in the target folder #20939

Open
Puneet1726 opened this issue Nov 27, 2024 · 2 comments
Labels
Triaged this issue has been triaged

Comments

@Puneet1726
Copy link

Puneet1726 commented Nov 27, 2024

Description

Steps to reproduce the issue:

  1. clone sonic repo to new path
  2. copy target folder from already built path
  3. run make configure PLATFORM=vs
  4. run make list
  5. run make target/docker-sonic-mgmt-framework-dbg.gz

Describe the results you received:

It is rebuilding deb packages even though they are already present in the target folder

Describe the results you expected:

It should just rebuild the docker gz file and should not rebuild the deb packages

Output of show version:

(paste your output here)

Output of show techsupport:

[ 01 ] [ target/debs/bookworm/libnl-3-200_3.5.0-1_amd64.deb ]
[ 02 ] [ target/debs/bookworm/libyang2_2.0.112-6_amd64.deb ]
[ 03 ] [ target/python-wheels/bookworm/redis_dump_load-1.1-py3-none-any.whl ]
[ 04 ] [ target/debs/bookworm/socat_1.7.4.1-3_amd64.deb ]
Removing patch ../redis-dump-load.patch/0002-Fix-setup.py-for-test-and-bdist_wheel.patch
Restoring setup.py

[ 01 ] [ target/python-wheels/bookworm/sonic_config_engine-1.0-py3-none-any.whl ]


We are trying to reduce the time to build sonic image/target by using pre built deb packages.
Right now it is rebuilding deb packages even though they are present in /target/deb/bookworm path after copying from another build directory.

We are trying reduce the time taken by each developer for the build. Any suggestion is appreciated

@Puneet1726 Puneet1726 changed the title Copying target folder to new sonic build image path and try to build vs image Rebuilding deb packages after copying the target folder to new sonic build image path and try to build vs image Nov 27, 2024
@Puneet1726 Puneet1726 changed the title Rebuilding deb packages after copying the target folder to new sonic build image path and try to build vs image make target is recreating deb packages even though they are present in the target folder Nov 28, 2024
@prabhataravind
Copy link
Contributor

@Puneet1726, could you check the design document for sonic build and see if there are any improvements that could help in this case? Could you also confirm if you see the same problem if you do a rebuild after at least one initial build (after cloning)?

@prabhataravind prabhataravind added the Triaged this issue has been triaged label Dec 4, 2024
@Puneet1726
Copy link
Author

Puneet1726 commented Dec 13, 2024

@prabhataravind : with SONIC_DPKG_CACHE_METHOD=rwcache target/docker-sonic-mgmt-framework.gz, I am able to reduce the inital build time but it takes around 15mins for sonic mgmt framework build for the first time after copying the prebuilt artifacts (copy full target folder).

Can we reduce it to 5mins? Do I need to copy any other folder/artifacts to achieve that from pre built path?

This problem is for initial build and it is fine after first build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Triaged this issue has been triaged
Projects
None yet
Development

No branches or pull requests

2 participants