-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[frr/bgpd] fix frr VXLAN EVPN configuration for unified config #21053
base: master
Are you sure you want to change the base?
Conversation
1b7d6ee
to
5cb6d10
Compare
rebased to force rebuild to see if general sonic CI tests are working yet |
@lguohan please review |
5cb6d10
to
39f8279
Compare
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
rebased to try to force rebuild since last build hung |
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
@tjchadaga I see you commented on #21034 (which this PR resolves) about some group triaging this. This is a pretty critical issue at this point since VXLAN EVPN won't come online without this. Any status update? A couple people have already reviewed and approved. @lguohan ping |
…net#21053) During debugging of VXLAN EVPN using unified vs split configuration, the same BGP configuration is made with one exception, the setting of ``` no fpm use-next-hop-groups ``` Is forcibly set for all FRR instances. This change was introduced in PR sonic-net#12852 when switching to the new fpm dataplane plugin. When running `vtysh -c "config" -c "no fpm use-next-hop-groups"` it can be seen the VTEP immediately comes online and traffic flows as expected. This adds the option as is present in dockers/docker-fpm-frr/frr/zebra/zebra.conf.j2 controlled by the DEVICE_METADATA nexthop_group option. Signed-off-by: Brad House (@bradh352)
During debugging of VXLAN EVPN using unified vs split configuration, the same BGP configuration is made with one exception, the setting of ``` no fpm use-next-hop-groups ``` Is forcibly set for all FRR instances. This change was introduced in PR sonic-net#12852 when switching to the new fpm dataplane plugin. When running `vtysh -c "config" -c "no fpm use-next-hop-groups"` it can be seen the VTEP immediately comes online and traffic flows as expected. This adds the option as is present in dockers/docker-fpm-frr/frr/zebra/zebra.conf.j2 controlled by the DEVICE_METADATA nexthop_group option. Signed-off-by: Brad House (@bradh352)
ac41ea7
to
02abfad
Compare
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
During debugging of VXLAN EVPN using unified vs split configuration, the same BGP configuration is made with one exception, the setting of ``` no fpm use-next-hop-groups ``` Is forcibly set for all FRR instances. This change was introduced in PR sonic-net#12852 when switching to the new fpm dataplane plugin. When running `vtysh -c "config" -c "no fpm use-next-hop-groups"` it can be seen the VTEP immediately comes online and traffic flows as expected. This adds the option as is present in dockers/docker-fpm-frr/frr/zebra/zebra.conf.j2 controlled by the DEVICE_METADATA nexthop_group option. Signed-off-by: Brad House (@bradh352)
During debugging of VXLAN EVPN using unified vs split configuration, the same BGP configuration is made with one exception, the setting of ``` no fpm use-next-hop-groups ``` Is forcibly set for all FRR instances. This change was introduced in PR sonic-net#12852 when switching to the new fpm dataplane plugin. When running `vtysh -c "config" -c "no fpm use-next-hop-groups"` it can be seen the VTEP immediately comes online and traffic flows as expected. This adds the option as is present in dockers/docker-fpm-frr/frr/zebra/zebra.conf.j2 controlled by the DEVICE_METADATA nexthop_group option. Signed-off-by: Brad House (@bradh352)
During debugging of VXLAN EVPN using unified vs split configuration, the same BGP configuration is made with one exception, the setting of ``` no fpm use-next-hop-groups ``` Is forcibly set for all FRR instances. This change was introduced in PR sonic-net#12852 when switching to the new fpm dataplane plugin. When running `vtysh -c "config" -c "no fpm use-next-hop-groups"` it can be seen the VTEP immediately comes online and traffic flows as expected. This adds the option as is present in dockers/docker-fpm-frr/frr/zebra/zebra.conf.j2 controlled by the DEVICE_METADATA nexthop_group option. Signed-off-by: Brad House (@bradh352)
During debugging of VXLAN EVPN using unified vs split configuration, the same BGP configuration is made with one exception, the setting of ``` no fpm use-next-hop-groups ``` Is forcibly set for all FRR instances. This change was introduced in PR sonic-net#12852 when switching to the new fpm dataplane plugin. When running `vtysh -c "config" -c "no fpm use-next-hop-groups"` it can be seen the VTEP immediately comes online and traffic flows as expected. This adds the option as is present in dockers/docker-fpm-frr/frr/zebra/zebra.conf.j2 controlled by the DEVICE_METADATA nexthop_group option. Signed-off-by: Brad House (@bradh352)
During debugging of VXLAN EVPN using unified vs split configuration, the same BGP configuration is made with one exception, the setting of ``` no fpm use-next-hop-groups ``` Is forcibly set for all FRR instances. This change was introduced in PR sonic-net#12852 when switching to the new fpm dataplane plugin. When running `vtysh -c "config" -c "no fpm use-next-hop-groups"` it can be seen the VTEP immediately comes online and traffic flows as expected. This adds the option as is present in dockers/docker-fpm-frr/frr/zebra/zebra.conf.j2 controlled by the DEVICE_METADATA nexthop_group option. Signed-off-by: Brad House (@bradh352)
During debugging of VXLAN EVPN using unified vs split configuration, the same BGP configuration is made with one exception, the setting of ``` no fpm use-next-hop-groups ``` Is forcibly set for all FRR instances. This change was introduced in PR sonic-net#12852 when switching to the new fpm dataplane plugin. When running `vtysh -c "config" -c "no fpm use-next-hop-groups"` it can be seen the VTEP immediately comes online and traffic flows as expected. This adds the option as is present in dockers/docker-fpm-frr/frr/zebra/zebra.conf.j2 controlled by the DEVICE_METADATA nexthop_group option. Signed-off-by: Brad House (@bradh352)
During debugging of VXLAN EVPN using unified vs split configuration, the same BGP configuration is made with one exception, the setting of ``` no fpm use-next-hop-groups ``` Is forcibly set for all FRR instances. This change was introduced in PR sonic-net#12852 when switching to the new fpm dataplane plugin. When running `vtysh -c "config" -c "no fpm use-next-hop-groups"` it can be seen the VTEP immediately comes online and traffic flows as expected. This adds the option as is present in dockers/docker-fpm-frr/frr/zebra/zebra.conf.j2 controlled by the DEVICE_METADATA nexthop_group option. Signed-off-by: Brad House (@bradh352)
During debugging of VXLAN EVPN using unified vs split configuration, the same BGP configuration is made with one exception, the setting of ``` no fpm use-next-hop-groups ``` Is forcibly set for all FRR instances. This change was introduced in PR sonic-net#12852 when switching to the new fpm dataplane plugin. When running `vtysh -c "config" -c "no fpm use-next-hop-groups"` it can be seen the VTEP immediately comes online and traffic flows as expected. This adds the option as is present in dockers/docker-fpm-frr/frr/zebra/zebra.conf.j2 controlled by the DEVICE_METADATA nexthop_group option. Signed-off-by: Brad House (@bradh352)
During debugging of VXLAN EVPN using unified vs split configuration, the same BGP configuration is made with one exception, the setting of ``` no fpm use-next-hop-groups ``` Is forcibly set for all FRR instances. This change was introduced in PR sonic-net#12852 when switching to the new fpm dataplane plugin. When running `vtysh -c "config" -c "no fpm use-next-hop-groups"` it can be seen the VTEP immediately comes online and traffic flows as expected. This adds the option as is present in dockers/docker-fpm-frr/frr/zebra/zebra.conf.j2 controlled by the DEVICE_METADATA nexthop_group option. Signed-off-by: Brad House (@bradh352)
During debugging of VXLAN EVPN using unified vs split configuration, the same BGP configuration is made with one exception, the setting of ``` no fpm use-next-hop-groups ``` Is forcibly set for all FRR instances. This change was introduced in PR sonic-net#12852 when switching to the new fpm dataplane plugin. When running `vtysh -c "config" -c "no fpm use-next-hop-groups"` it can be seen the VTEP immediately comes online and traffic flows as expected. This adds the option as is present in dockers/docker-fpm-frr/frr/zebra/zebra.conf.j2 controlled by the DEVICE_METADATA nexthop_group option. Signed-off-by: Brad House (@bradh352)
During debugging of VXLAN EVPN using unified vs split configuration, the same BGP configuration is made with one exception, the setting of ``` no fpm use-next-hop-groups ``` Is forcibly set for all FRR instances. This change was introduced in PR sonic-net#12852 when switching to the new fpm dataplane plugin. When running `vtysh -c "config" -c "no fpm use-next-hop-groups"` it can be seen the VTEP immediately comes online and traffic flows as expected. This adds the option as is present in dockers/docker-fpm-frr/frr/zebra/zebra.conf.j2 controlled by the DEVICE_METADATA nexthop_group option. Signed-off-by: Brad House (@bradh352)
…net#21053) During debugging of VXLAN EVPN using unified vs split configuration, the same BGP configuration is made with one exception, the setting of ``` no fpm use-next-hop-groups ``` Is forcibly set for all FRR instances. This change was introduced in PR sonic-net#12852 when switching to the new fpm dataplane plugin. When running `vtysh -c "config" -c "no fpm use-next-hop-groups"` it can be seen the VTEP immediately comes online and traffic flows as expected. This adds the option as is present in dockers/docker-fpm-frr/frr/zebra/zebra.conf.j2 controlled by the DEVICE_METADATA nexthop_group option. Signed-off-by: Brad House (@bradh352)
During debugging of VXLAN EVPN using unified vs split configuration, the same BGP configuration is made with one exception, the setting of ``` no fpm use-next-hop-groups ``` Is forcibly set for all FRR instances. This change was introduced in PR sonic-net#12852 when switching to the new fpm dataplane plugin. When running `vtysh -c "config" -c "no fpm use-next-hop-groups"` it can be seen the VTEP immediately comes online and traffic flows as expected. This adds the option as is present in dockers/docker-fpm-frr/frr/zebra/zebra.conf.j2 controlled by the DEVICE_METADATA nexthop_group option. Signed-off-by: Brad House (@bradh352)
During debugging of VXLAN EVPN using unified vs split configuration, the same BGP configuration is made with one exception, the setting of ``` no fpm use-next-hop-groups ``` Is forcibly set for all FRR instances. This change was introduced in PR sonic-net#12852 when switching to the new fpm dataplane plugin. When running `vtysh -c "config" -c "no fpm use-next-hop-groups"` it can be seen the VTEP immediately comes online and traffic flows as expected. This adds the option as is present in dockers/docker-fpm-frr/frr/zebra/zebra.conf.j2 controlled by the DEVICE_METADATA nexthop_group option. Signed-off-by: Brad House (@bradh352)
During debugging of VXLAN EVPN using unified vs split configuration, the same BGP configuration is made with one exception, the setting of ``` no fpm use-next-hop-groups ``` Is forcibly set for all FRR instances. This change was introduced in PR sonic-net#12852 when switching to the new fpm dataplane plugin. When running `vtysh -c "config" -c "no fpm use-next-hop-groups"` it can be seen the VTEP immediately comes online and traffic flows as expected. This adds the option as is present in dockers/docker-fpm-frr/frr/zebra/zebra.conf.j2 controlled by the DEVICE_METADATA nexthop_group option. Signed-off-by: Brad House (@bradh352)
During debugging of VXLAN EVPN using unified vs split configuration, the same BGP configuration is made with one exception, the setting of ``` no fpm use-next-hop-groups ``` Is forcibly set for all FRR instances. This change was introduced in PR sonic-net#12852 when switching to the new fpm dataplane plugin. When running `vtysh -c "config" -c "no fpm use-next-hop-groups"` it can be seen the VTEP immediately comes online and traffic flows as expected. This adds the option as is present in dockers/docker-fpm-frr/frr/zebra/zebra.conf.j2 controlled by the DEVICE_METADATA nexthop_group option. Signed-off-by: Brad House (@bradh352)
During debugging of VXLAN EVPN using unified vs split configuration, the same BGP configuration is made with one exception, the setting of ``` no fpm use-next-hop-groups ``` Is forcibly set for all FRR instances. This change was introduced in PR sonic-net#12852 when switching to the new fpm dataplane plugin. When running `vtysh -c "config" -c "no fpm use-next-hop-groups"` it can be seen the VTEP immediately comes online and traffic flows as expected. This adds the option as is present in dockers/docker-fpm-frr/frr/zebra/zebra.conf.j2 controlled by the DEVICE_METADATA nexthop_group option. Signed-off-by: Brad House (@bradh352)
During debugging of VXLAN EVPN using unified vs split configuration, the same BGP configuration is made with one exception, the setting of ``` no fpm use-next-hop-groups ``` Is forcibly set for all FRR instances. This change was introduced in PR sonic-net#12852 when switching to the new fpm dataplane plugin. When running `vtysh -c "config" -c "no fpm use-next-hop-groups"` it can be seen the VTEP immediately comes online and traffic flows as expected. This adds the option as is present in dockers/docker-fpm-frr/frr/zebra/zebra.conf.j2 controlled by the DEVICE_METADATA nexthop_group option. Signed-off-by: Brad House (@bradh352)
During debugging of VXLAN EVPN using unified vs split configuration, the same BGP configuration is made with one exception, the setting of ``` no fpm use-next-hop-groups ``` Is forcibly set for all FRR instances. This change was introduced in PR sonic-net#12852 when switching to the new fpm dataplane plugin. When running `vtysh -c "config" -c "no fpm use-next-hop-groups"` it can be seen the VTEP immediately comes online and traffic flows as expected. This adds the option as is present in dockers/docker-fpm-frr/frr/zebra/zebra.conf.j2 controlled by the DEVICE_METADATA nexthop_group option. Signed-off-by: Brad House (@bradh352)
During debugging of VXLAN EVPN using unified vs split configuration, the same BGP configuration is made with one exception, the setting of ``` no fpm use-next-hop-groups ``` Is forcibly set for all FRR instances. This change was introduced in PR sonic-net#12852 when switching to the new fpm dataplane plugin. When running `vtysh -c "config" -c "no fpm use-next-hop-groups"` it can be seen the VTEP immediately comes online and traffic flows as expected. This adds the option as is present in dockers/docker-fpm-frr/frr/zebra/zebra.conf.j2 controlled by the DEVICE_METADATA nexthop_group option. Signed-off-by: Brad House (@bradh352)
During debugging of VXLAN EVPN using unified vs split configuration, the same BGP configuration is made with one exception, the setting of ``` no fpm use-next-hop-groups ``` Is forcibly set for all FRR instances. This change was introduced in PR sonic-net#12852 when switching to the new fpm dataplane plugin. When running `vtysh -c "config" -c "no fpm use-next-hop-groups"` it can be seen the VTEP immediately comes online and traffic flows as expected. This adds the option as is present in dockers/docker-fpm-frr/frr/zebra/zebra.conf.j2 controlled by the DEVICE_METADATA nexthop_group option. Signed-off-by: Brad House (@bradh352)
During debugging of VXLAN EVPN using unified vs split configuration, the same BGP configuration is made with one exception, the setting of ``` no fpm use-next-hop-groups ``` Is forcibly set for all FRR instances. This change was introduced in PR sonic-net#12852 when switching to the new fpm dataplane plugin. When running `vtysh -c "config" -c "no fpm use-next-hop-groups"` it can be seen the VTEP immediately comes online and traffic flows as expected. This adds the option as is present in dockers/docker-fpm-frr/frr/zebra/zebra.conf.j2 controlled by the DEVICE_METADATA nexthop_group option. Signed-off-by: Brad House (@bradh352)
During debugging of VXLAN EVPN using unified vs split configuration, the same BGP configuration is made with one exception, the setting of ``` no fpm use-next-hop-groups ``` Is forcibly set for all FRR instances. This change was introduced in PR sonic-net#12852 when switching to the new fpm dataplane plugin. When running `vtysh -c "config" -c "no fpm use-next-hop-groups"` it can be seen the VTEP immediately comes online and traffic flows as expected. This adds the option as is present in dockers/docker-fpm-frr/frr/zebra/zebra.conf.j2 controlled by the DEVICE_METADATA nexthop_group option. Signed-off-by: Brad House (@bradh352)
During debugging of VXLAN EVPN using unified vs split configuration, the same BGP configuration is made with one exception, the setting of ``` no fpm use-next-hop-groups ``` Is forcibly set for all FRR instances. This change was introduced in PR sonic-net#12852 when switching to the new fpm dataplane plugin. When running `vtysh -c "config" -c "no fpm use-next-hop-groups"` it can be seen the VTEP immediately comes online and traffic flows as expected. This adds the option as is present in dockers/docker-fpm-frr/frr/zebra/zebra.conf.j2 controlled by the DEVICE_METADATA nexthop_group option. Signed-off-by: Brad House (@bradh352)
During debugging of VXLAN EVPN using unified vs split configuration, the same BGP configuration is made with one exception, the setting of ``` no fpm use-next-hop-groups ``` Is forcibly set for all FRR instances. This change was introduced in PR sonic-net#12852 when switching to the new fpm dataplane plugin. When running `vtysh -c "config" -c "no fpm use-next-hop-groups"` it can be seen the VTEP immediately comes online and traffic flows as expected. This adds the option as is present in dockers/docker-fpm-frr/frr/zebra/zebra.conf.j2 controlled by the DEVICE_METADATA nexthop_group option. Signed-off-by: Brad House (@bradh352)
During debugging of VXLAN EVPN using unified vs split configuration, the same BGP configuration is made with one exception, the setting of ``` no fpm use-next-hop-groups ``` Is forcibly set for all FRR instances. This change was introduced in PR sonic-net#12852 when switching to the new fpm dataplane plugin. When running `vtysh -c "config" -c "no fpm use-next-hop-groups"` it can be seen the VTEP immediately comes online and traffic flows as expected. This adds the option as is present in dockers/docker-fpm-frr/frr/zebra/zebra.conf.j2 controlled by the DEVICE_METADATA nexthop_group option. Signed-off-by: Brad House (@bradh352)
During debugging of VXLAN EVPN using unified vs split configuration, the same BGP configuration is made with one exception, the setting of ``` no fpm use-next-hop-groups ``` Is forcibly set for all FRR instances. This change was introduced in PR sonic-net#12852 when switching to the new fpm dataplane plugin. When running `vtysh -c "config" -c "no fpm use-next-hop-groups"` it can be seen the VTEP immediately comes online and traffic flows as expected. This adds the option as is present in dockers/docker-fpm-frr/frr/zebra/zebra.conf.j2 controlled by the DEVICE_METADATA nexthop_group option. Signed-off-by: Brad House (@bradh352)
During debugging of VXLAN EVPN using unified vs split configuration, the same BGP configuration is made with one exception, the setting of ``` no fpm use-next-hop-groups ``` Is forcibly set for all FRR instances. This change was introduced in PR sonic-net#12852 when switching to the new fpm dataplane plugin. When running `vtysh -c "config" -c "no fpm use-next-hop-groups"` it can be seen the VTEP immediately comes online and traffic flows as expected. This adds the option as is present in dockers/docker-fpm-frr/frr/zebra/zebra.conf.j2 controlled by the DEVICE_METADATA nexthop_group option. Signed-off-by: Brad House (@bradh352)
During debugging of VXLAN EVPN using unified vs split configuration, the same BGP configuration is made with one exception, the setting of ``` no fpm use-next-hop-groups ``` Is forcibly set for all FRR instances. This change was introduced in PR sonic-net#12852 when switching to the new fpm dataplane plugin. When running `vtysh -c "config" -c "no fpm use-next-hop-groups"` it can be seen the VTEP immediately comes online and traffic flows as expected. This adds the option as is present in dockers/docker-fpm-frr/frr/zebra/zebra.conf.j2 controlled by the DEVICE_METADATA nexthop_group option. Signed-off-by: Brad House (@bradh352)
During debugging of VXLAN EVPN using unified vs split configuration, the same BGP configuration is made with one exception, the setting of ``` no fpm use-next-hop-groups ``` Is forcibly set for all FRR instances. This change was introduced in PR sonic-net#12852 when switching to the new fpm dataplane plugin. When running `vtysh -c "config" -c "no fpm use-next-hop-groups"` it can be seen the VTEP immediately comes online and traffic flows as expected. This adds the option as is present in dockers/docker-fpm-frr/frr/zebra/zebra.conf.j2 controlled by the DEVICE_METADATA nexthop_group option. Signed-off-by: Brad House (@bradh352)
During debugging of VXLAN EVPN using unified vs split configuration, the same BGP configuration is made with one exception, the setting of ``` no fpm use-next-hop-groups ``` Is forcibly set for all FRR instances. This change was introduced in PR sonic-net#12852 when switching to the new fpm dataplane plugin. When running `vtysh -c "config" -c "no fpm use-next-hop-groups"` it can be seen the VTEP immediately comes online and traffic flows as expected. This adds the option as is present in dockers/docker-fpm-frr/frr/zebra/zebra.conf.j2 controlled by the DEVICE_METADATA nexthop_group option. Signed-off-by: Brad House (@bradh352)
Why I did it
During debugging of VXLAN EVPN using unified vs split configuration, the same BGP configuration is made with one exception, the setting of
no fpm use-next-hop-groups
which is forcibly set for all FRR instances.This change was introduced in PR #12852 when switching to the new fpm dataplane plugin.
When running
vtysh -c "config" -c "no fpm use-next-hop-groups"
it can be seen the VTEP immediately comes online and traffic flows as expected.Work item tracking
How I did it
This adds the option as is present in dockers/docker-fpm-frr/frr/zebra/zebra.conf.j2 controlled by the DEVICE_METADATA nexthop_group option.
How to verify it
See #21034 for details
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
master as of 20241205
Description for the changelog
[frr/bgpd] fix frr VXLAN EVPN configuration for unified config
Link to config_db schema for YANG module changes
N/A
A picture of a cute animal (not mandatory but encouraged)
Fixes #21034
Signed-off-by: Brad House (@bradh352)