From 173d7547417ac3a54c07a847ba16817bbed58e2f Mon Sep 17 00:00:00 2001 From: Fernando Maia Date: Tue, 12 Jan 2021 13:06:02 -0300 Subject: [PATCH 01/11] Add networking.k8s.io/v1 support --- .../sorry-cypress/templates/ingress-api.yml | 19 ++++++++++++++--- .../templates/ingress-dashboard.yml | 21 +++++++++++++++---- .../templates/ingress-director.yml | 21 +++++++++++++++---- 3 files changed, 50 insertions(+), 11 deletions(-) diff --git a/charts/sorry-cypress/templates/ingress-api.yml b/charts/sorry-cypress/templates/ingress-api.yml index ce29592..2ef766a 100644 --- a/charts/sorry-cypress/templates/ingress-api.yml +++ b/charts/sorry-cypress/templates/ingress-api.yml @@ -1,7 +1,10 @@ {{- if .Values.api.ingress.hosts -}} +{{- $v1Networking := .Capabilities.APIVersions.Has "networking.k8s.io/v1" -}} {{- $fullName := include "sorry-cypress-helm.fullname" . -}} -{{- $svcPort := .Values.api.service.port -}} -{{- if semverCompare ">=1.14-0" .Capabilities.KubeVersion.GitVersion -}} +{{- $servicePort := .Values.api.service.port -}} +{{- if $v1Networking }} +apiVersion: networking.k8s.io/v1 +{{- else if .Capabilities.APIVersions.Has "networking.k8s.io/v1beta1" }} apiVersion: networking.k8s.io/v1beta1 {{- else -}} apiVersion: extensions/v1beta1 @@ -31,8 +34,18 @@ spec: - host: {{ .host | quote }} http: paths: + {{- if $v1Networking }} + - path: / + pathType: Prefix + backend: + service: + name: {{ $fullName }}-api + port: + number: {{ $servicePort }} + {{- else -}} - backend: serviceName: {{ $fullName }}-api - servicePort: {{ $svcPort }} + servicePort: {{ $servicePort }} + {{- end }} {{- end }} {{- end }} \ No newline at end of file diff --git a/charts/sorry-cypress/templates/ingress-dashboard.yml b/charts/sorry-cypress/templates/ingress-dashboard.yml index 8f23522..61bd1a9 100644 --- a/charts/sorry-cypress/templates/ingress-dashboard.yml +++ b/charts/sorry-cypress/templates/ingress-dashboard.yml @@ -1,7 +1,10 @@ {{- if .Values.dashboard.ingress.enabled -}} +{{- $v1Networking := .Capabilities.APIVersions.Has "networking.k8s.io/v1" -}} {{- $fullName := include "sorry-cypress-helm.fullname" . -}} -{{- $svcPort := .Values.dashboard.service.port -}} -{{- if semverCompare ">=1.14-0" .Capabilities.KubeVersion.GitVersion -}} +{{- $servicePort := .Values.dashboard.service.port -}} +{{- if $v1Networking }} +apiVersion: networking.k8s.io/v1 +{{- else if .Capabilities.APIVersions.Has "networking.k8s.io/v1beta1" }} apiVersion: networking.k8s.io/v1beta1 {{- else -}} apiVersion: extensions/v1beta1 @@ -31,8 +34,18 @@ spec: - host: {{ .host | quote }} http: paths: + {{- if $v1Networking }} + - path: / + pathType: Prefix + backend: + service: + name: {{ $fullName }}-api + port: + number: {{ $servicePort }} + {{- else -}} - backend: - serviceName: {{ $fullName }}-dashboard - servicePort: {{ $svcPort }} + serviceName: {{ $fullName }}-api + servicePort: {{ $servicePort }} + {{- end }} {{- end }} {{- end }} \ No newline at end of file diff --git a/charts/sorry-cypress/templates/ingress-director.yml b/charts/sorry-cypress/templates/ingress-director.yml index 63ab4fe..13a8924 100644 --- a/charts/sorry-cypress/templates/ingress-director.yml +++ b/charts/sorry-cypress/templates/ingress-director.yml @@ -1,7 +1,10 @@ {{- if .Values.director.ingress.enabled -}} +{{- $v1Networking := .Capabilities.APIVersions.Has "networking.k8s.io/v1" -}} {{- $fullName := include "sorry-cypress-helm.fullname" . -}} -{{- $svcPort := .Values.director.service.port -}} -{{- if semverCompare ">=1.14-0" .Capabilities.KubeVersion.GitVersion -}} +{{- $servicePort := .Values.director.service.port -}} +{{- if $v1Networking }} +apiVersion: networking.k8s.io/v1 +{{- else if .Capabilities.APIVersions.Has "networking.k8s.io/v1beta1" }} apiVersion: networking.k8s.io/v1beta1 {{- else -}} apiVersion: extensions/v1beta1 @@ -31,8 +34,18 @@ spec: - host: {{ .host | quote }} http: paths: + {{- if $v1Networking }} + - path: / + pathType: Prefix + backend: + service: + name: {{ $fullName }}-api + port: + number: {{ $servicePort }} + {{- else -}} - backend: - serviceName: {{ $fullName }}-director - servicePort: {{ $svcPort }} + serviceName: {{ $fullName }}-api + servicePort: {{ $servicePort }} + {{- end }} {{- end }} {{- end }} \ No newline at end of file From c7143d38995b1a83d0a9889f50940ccd07d419f9 Mon Sep 17 00:00:00 2001 From: Fernando Maia Date: Tue, 12 Jan 2021 13:08:55 -0300 Subject: [PATCH 02/11] Bump chart version to 0.1.11 --- charts/sorry-cypress/Chart.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/charts/sorry-cypress/Chart.yaml b/charts/sorry-cypress/Chart.yaml index ecd7bde..f11c06c 100644 --- a/charts/sorry-cypress/Chart.yaml +++ b/charts/sorry-cypress/Chart.yaml @@ -2,7 +2,7 @@ apiVersion: v2 name: sorry-cypress description: A Helm chart for Sorry Cypress type: application -version: 0.1.9 +version: 0.1.11 appVersion: 0.6.1 home: https://sorry-cypress.dev/ sources: From 356f32c7f2141a2952430e87dab9e1aae0ad53cb Mon Sep 17 00:00:00 2001 From: Fernando Maia Date: Tue, 12 Jan 2021 13:27:02 -0300 Subject: [PATCH 03/11] Fix networking.k8s.io/v1beta1 support --- charts/sorry-cypress/templates/ingress-api.yml | 2 +- charts/sorry-cypress/templates/ingress-dashboard.yml | 2 +- charts/sorry-cypress/templates/ingress-director.yml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/charts/sorry-cypress/templates/ingress-api.yml b/charts/sorry-cypress/templates/ingress-api.yml index 2ef766a..b3f2f69 100644 --- a/charts/sorry-cypress/templates/ingress-api.yml +++ b/charts/sorry-cypress/templates/ingress-api.yml @@ -42,7 +42,7 @@ spec: name: {{ $fullName }}-api port: number: {{ $servicePort }} - {{- else -}} + {{- else }} - backend: serviceName: {{ $fullName }}-api servicePort: {{ $servicePort }} diff --git a/charts/sorry-cypress/templates/ingress-dashboard.yml b/charts/sorry-cypress/templates/ingress-dashboard.yml index 61bd1a9..58188c2 100644 --- a/charts/sorry-cypress/templates/ingress-dashboard.yml +++ b/charts/sorry-cypress/templates/ingress-dashboard.yml @@ -42,7 +42,7 @@ spec: name: {{ $fullName }}-api port: number: {{ $servicePort }} - {{- else -}} + {{- else }} - backend: serviceName: {{ $fullName }}-api servicePort: {{ $servicePort }} diff --git a/charts/sorry-cypress/templates/ingress-director.yml b/charts/sorry-cypress/templates/ingress-director.yml index 13a8924..3051cb8 100644 --- a/charts/sorry-cypress/templates/ingress-director.yml +++ b/charts/sorry-cypress/templates/ingress-director.yml @@ -42,7 +42,7 @@ spec: name: {{ $fullName }}-api port: number: {{ $servicePort }} - {{- else -}} + {{- else }} - backend: serviceName: {{ $fullName }}-api servicePort: {{ $servicePort }} From 46f5bc432b08d9e76dc89d3473432d4b1509b1c4 Mon Sep 17 00:00:00 2001 From: Fernando Maia Date: Tue, 12 Jan 2021 13:41:25 -0300 Subject: [PATCH 04/11] Fix networking.k8s.io/v1beta1 support --- charts/sorry-cypress/templates/ingress-api.yml | 2 +- charts/sorry-cypress/templates/ingress-dashboard.yml | 2 +- charts/sorry-cypress/templates/ingress-director.yml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/charts/sorry-cypress/templates/ingress-api.yml b/charts/sorry-cypress/templates/ingress-api.yml index b3f2f69..7bf84c3 100644 --- a/charts/sorry-cypress/templates/ingress-api.yml +++ b/charts/sorry-cypress/templates/ingress-api.yml @@ -1,5 +1,5 @@ {{- if .Values.api.ingress.hosts -}} -{{- $v1Networking := .Capabilities.APIVersions.Has "networking.k8s.io/v1" -}} +{{- $v1Networking := .Capabilities.APIVersions.Has "networking.k8s.io/v1/Ingress" -}} {{- $fullName := include "sorry-cypress-helm.fullname" . -}} {{- $servicePort := .Values.api.service.port -}} {{- if $v1Networking }} diff --git a/charts/sorry-cypress/templates/ingress-dashboard.yml b/charts/sorry-cypress/templates/ingress-dashboard.yml index 58188c2..ef84284 100644 --- a/charts/sorry-cypress/templates/ingress-dashboard.yml +++ b/charts/sorry-cypress/templates/ingress-dashboard.yml @@ -1,5 +1,5 @@ {{- if .Values.dashboard.ingress.enabled -}} -{{- $v1Networking := .Capabilities.APIVersions.Has "networking.k8s.io/v1" -}} +{{- $v1Networking := .Capabilities.APIVersions.Has "networking.k8s.io/v1/Ingress" -}} {{- $fullName := include "sorry-cypress-helm.fullname" . -}} {{- $servicePort := .Values.dashboard.service.port -}} {{- if $v1Networking }} diff --git a/charts/sorry-cypress/templates/ingress-director.yml b/charts/sorry-cypress/templates/ingress-director.yml index 3051cb8..94d3969 100644 --- a/charts/sorry-cypress/templates/ingress-director.yml +++ b/charts/sorry-cypress/templates/ingress-director.yml @@ -1,5 +1,5 @@ {{- if .Values.director.ingress.enabled -}} -{{- $v1Networking := .Capabilities.APIVersions.Has "networking.k8s.io/v1" -}} +{{- $v1Networking := .Capabilities.APIVersions.Has "networking.k8s.io/v1/Ingress" -}} {{- $fullName := include "sorry-cypress-helm.fullname" . -}} {{- $servicePort := .Values.director.service.port -}} {{- if $v1Networking }} From 56c41ab8ab8b11cc565929d37a0e6ad44938e1b4 Mon Sep 17 00:00:00 2001 From: Fernando Maia Date: Tue, 12 Jan 2021 17:35:35 -0300 Subject: [PATCH 05/11] Bump chart version to 0.1.12 --- charts/sorry-cypress/Chart.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/charts/sorry-cypress/Chart.yaml b/charts/sorry-cypress/Chart.yaml index f11c06c..dcdf073 100644 --- a/charts/sorry-cypress/Chart.yaml +++ b/charts/sorry-cypress/Chart.yaml @@ -2,7 +2,7 @@ apiVersion: v2 name: sorry-cypress description: A Helm chart for Sorry Cypress type: application -version: 0.1.11 +version: 0.1.12 appVersion: 0.6.1 home: https://sorry-cypress.dev/ sources: From 2f9bb5565f25d10e4ed569d26c291436da306e5c Mon Sep 17 00:00:00 2001 From: Fernando Maia Date: Tue, 12 Jan 2021 20:41:02 -0300 Subject: [PATCH 06/11] Add podAnnotations and podLabels to deployments --- README.md | 8 +++++++ .../templates/deployment-api.yml | 9 ++++++- .../templates/deployment-dashboard.yml | 9 ++++++- .../templates/deployment-director.yml | 9 ++++++- .../templates/deployment-mongo.yml | 9 ++++++- charts/sorry-cypress/values.yaml | 24 +++++++++++++++++++ 6 files changed, 64 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index 9e3a47e..82e2e7f 100644 --- a/README.md +++ b/README.md @@ -63,6 +63,8 @@ https://sorry-cypress.dev/api#configuration | `api.image.tag` | Image tag | `latest` | | `api.image.pullPolicy` | Image pull policy | `Always` | | `api.resources` | Resources to initialize the container | `{}` | +| `api.podAnnotations` | Set annotations for pods | `{}` | +| `api.podLabels` | Set additional labels for pods | `{}` | | `api.service.port` | Kubernetes service port | `4000` | | `api.ingress.labels` | Ingress labels | `{}` | | `api.ingress.annotations` | Ingress annotations | `{}` | @@ -81,6 +83,8 @@ https://sorry-cypress.dev/dashboard#configuration | `dashboard.resources` | Resources to initialize the container | `{}` | | `dashboard.environmentVariables.ciUrl` | Set optional environment variable `CI_URL` to add a link to your CI tool | `""` | | `dashboard.environmentVariables.graphQlSchemaUrl` | Set the environment variable `GRAPHQL_SCHEMA_URL` with the URL of API service. | `""` | +| `dashboard.podAnnotations` | Set annotations for pods | `{}` | +| `dashboard.podLabels` | Set additional labels for pods | `{}` | | `dashboard.service.port` | Kubernetes service port | `4000` | | `dashboard.ingress.enabled` | Flag to define if the dashboard service ingress is enabled | `true` | | `dashboard.ingress.labels` | Ingress labels | `{}` | @@ -107,6 +111,8 @@ https://sorry-cypress.dev/director/configuration | `director.s3.region` | Set the screenshots storage bucket region, if the screenshots driver is set to `"../screenshots/s3.driver"` | `us-east-1` | | `director.s3.accessKey` | The `AWS_ACCESS_KEY_ID` environment variable to configure AWS credentials, if the screenshots driver is set to `"../screenshots/s3.driver"` | `abc` | | `director.s3.secretAccessKey` | The `AWS_SECRET_ACCESS_KEY` environment variable to configure AWS credentials, if the screenshots driver is set to `"../screenshots/s3.driver"` | `zyx` | +| `director.podAnnotations` | Set annotations for pods | `{}` | +| `director.podLabels` | Set additional labels for pods | `{}` | | `director.service.port` | Kubernetes service port | `4000` | | `director.ingress.enabled` | Flag to define if the director service ingress is enabled | `true` | | `director.ingress.labels` | Ingress labels | `{}` | @@ -129,4 +135,6 @@ If the execution driver is set to `"../execution/mongo/driver"`, you may enable | `mongo.persistence.accessMode` | Volumes access mode to be set | `ReadWriteOnce` | | `mongo.persistence.size` | Size of the volume | `1Gi` | | `mongo.resources` | Resources to initialize the container | `{}` | +| `mongo.podAnnotations` | Set annotations for pods | `{}` | +| `mongo.podLabels` | Set additional labels for pods | `{}` | | `mongo.service.port` | Kubernetes service port | `4000` | diff --git a/charts/sorry-cypress/templates/deployment-api.yml b/charts/sorry-cypress/templates/deployment-api.yml index 6cae133..2822df4 100644 --- a/charts/sorry-cypress/templates/deployment-api.yml +++ b/charts/sorry-cypress/templates/deployment-api.yml @@ -11,9 +11,16 @@ spec: app: {{ include "sorry-cypress-helm.fullname" . }}-api template: metadata: + name: {{ include "sorry-cypress-helm.fullname" . }}-api labels: app: {{ include "sorry-cypress-helm.fullname" . }}-api - name: {{ include "sorry-cypress-helm.fullname" . }}-api + {{- with .Values.api.podLabels }} + {{- toYaml . | nindent 8 }} + {{- end}} + {{- with .Values.api.podAnnotations }} + annotations: + {{- toYaml . | nindent 8 }} + {{- end }} spec: containers: - env: diff --git a/charts/sorry-cypress/templates/deployment-dashboard.yml b/charts/sorry-cypress/templates/deployment-dashboard.yml index 7625da3..5732f0b 100644 --- a/charts/sorry-cypress/templates/deployment-dashboard.yml +++ b/charts/sorry-cypress/templates/deployment-dashboard.yml @@ -11,9 +11,16 @@ spec: app: {{ include "sorry-cypress-helm.fullname" . }}-dashboard template: metadata: + name: {{ include "sorry-cypress-helm.fullname" . }}-dashboard labels: app: {{ include "sorry-cypress-helm.fullname" . }}-dashboard - name: {{ include "sorry-cypress-helm.fullname" . }}-dashboard + {{- with .Values.dashboard.podLabels }} + {{- toYaml . | nindent 8 }} + {{- end}} + {{- with .Values.dashboard.podAnnotations }} + annotations: + {{- toYaml . | nindent 8 }} + {{- end }} spec: containers: - env: diff --git a/charts/sorry-cypress/templates/deployment-director.yml b/charts/sorry-cypress/templates/deployment-director.yml index e1dade4..9923d1e 100644 --- a/charts/sorry-cypress/templates/deployment-director.yml +++ b/charts/sorry-cypress/templates/deployment-director.yml @@ -9,9 +9,16 @@ spec: app: {{ include "sorry-cypress-helm.fullname" . }}-director template: metadata: + name: {{ include "sorry-cypress-helm.fullname" . }}-director labels: app: {{ include "sorry-cypress-helm.fullname" . }}-director - name: {{ include "sorry-cypress-helm.fullname" . }}-director + {{- with .Values.director.podLabels }} + {{- toYaml . | nindent 8 }} + {{- end}} + {{- with .Values.director.podAnnotations }} + annotations: + {{- toYaml . | nindent 8 }} + {{- end }} spec: containers: - env: diff --git a/charts/sorry-cypress/templates/deployment-mongo.yml b/charts/sorry-cypress/templates/deployment-mongo.yml index 4350a03..6b506a0 100644 --- a/charts/sorry-cypress/templates/deployment-mongo.yml +++ b/charts/sorry-cypress/templates/deployment-mongo.yml @@ -10,9 +10,16 @@ spec: app: {{ include "sorry-cypress-helm.fullname" . }}-mongo template: metadata: + name: {{ include "sorry-cypress-helm.fullname" . }}-mongo labels: app: {{ include "sorry-cypress-helm.fullname" . }}-mongo - name: {{ include "sorry-cypress-helm.fullname" . }}-mongo + {{- with .Values.mongo.podLabels }} + {{- toYaml . | nindent 8 }} + {{- end}} + {{- with .Values.mongo.podAnnotations }} + annotations: + {{- toYaml . | nindent 8 }} + {{- end }} spec: containers: - image: "{{ .Values.mongo.image.repository }}:{{ .Values.mongo.image.tag | default .Chart.AppVersion }}" diff --git a/charts/sorry-cypress/values.yaml b/charts/sorry-cypress/values.yaml index 96e4ea7..fa4a6c1 100644 --- a/charts/sorry-cypress/values.yaml +++ b/charts/sorry-cypress/values.yaml @@ -24,6 +24,12 @@ api: service: port: 4000 + # Set annotations for pods + podAnnotations: {} + + # Additional pod labels + podLabels: {} + ingress: labels: {} annotations: {} @@ -63,6 +69,12 @@ dashboard: service: port: 8080 + # Set annotations for pods + podAnnotations: {} + + # Additional pod labels + podLabels: {} + ingress: enabled: true labels: {} @@ -125,6 +137,12 @@ director: accessKeyId: abc secretAccessKey: zyx + # Set annotations for pods + podAnnotations: {} + + # Additional pod labels + podLabels: {} + service: port: 1234 @@ -172,5 +190,11 @@ mongo: # cpu: 100m # memory: 128Mi + # Set annotations for pods + podAnnotations: {} + + # Additional pod labels + podLabels: {} + service: port: 27017 From bcc3778329da855888b385a8c1c859c102ae9653 Mon Sep 17 00:00:00 2001 From: Fernando Maia Date: Tue, 12 Jan 2021 20:42:55 -0300 Subject: [PATCH 07/11] Bump chart version to 0.1.11 --- charts/sorry-cypress/Chart.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/charts/sorry-cypress/Chart.yaml b/charts/sorry-cypress/Chart.yaml index 9be443e..f11c06c 100644 --- a/charts/sorry-cypress/Chart.yaml +++ b/charts/sorry-cypress/Chart.yaml @@ -2,7 +2,7 @@ apiVersion: v2 name: sorry-cypress description: A Helm chart for Sorry Cypress type: application -version: 0.1.10 +version: 0.1.11 appVersion: 0.6.1 home: https://sorry-cypress.dev/ sources: From adb3d775d558b8696aad4dbccb757a7041153f44 Mon Sep 17 00:00:00 2001 From: tim-sendible Date: Wed, 13 Jan 2021 08:56:21 +0000 Subject: [PATCH 08/11] Closes #4 - pull PR/Issue templates from Sorry Cypress --- .github/ISSUE_TEMPLATE/bug-report.md | 16 ++++++++++++++++ .github/ISSUE_TEMPLATE/feature-request.md | 14 ++++++++++++++ 2 files changed, 30 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/bug-report.md create mode 100644 .github/ISSUE_TEMPLATE/feature-request.md diff --git a/.github/ISSUE_TEMPLATE/bug-report.md b/.github/ISSUE_TEMPLATE/bug-report.md new file mode 100644 index 0000000..20890f4 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/bug-report.md @@ -0,0 +1,16 @@ +--- +name: Bug Report +about: A bug 🐞 +--- + +## Summary + +Sorry cypress does X, but should do Y + +## How to reproduce + +## Environment + +- sorry-cypress version: `` +- cypress version: `` +- helm chart version: `` diff --git a/.github/ISSUE_TEMPLATE/feature-request.md b/.github/ISSUE_TEMPLATE/feature-request.md new file mode 100644 index 0000000..040bf3b --- /dev/null +++ b/.github/ISSUE_TEMPLATE/feature-request.md @@ -0,0 +1,14 @@ +--- +name: Feature Request +about: Create a feature request for Sorry Cypress Helm +--- + +- [ ] I have searched issues for similar feature requests + +## What is this feature about (1 sentence) + +## Why is it needed? What is the value? For whom do we build it? + +## High-level feature overview + +## Other From 8747b57227d9e3c788bcd0e1b2016ba7d16f4bfa Mon Sep 17 00:00:00 2001 From: Fernando Maia Date: Wed, 13 Jan 2021 11:14:27 -0300 Subject: [PATCH 09/11] Update KinD to the latest version --- .github/workflows/lint-test.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/lint-test.yml b/.github/workflows/lint-test.yml index bb6dffe..908cfd4 100644 --- a/.github/workflows/lint-test.yml +++ b/.github/workflows/lint-test.yml @@ -1,6 +1,6 @@ name: Lint and Test Charts -on: +on: pull_request: branches: - main @@ -43,8 +43,8 @@ jobs: - name: Create kind cluster uses: helm/kind-action@v1.1.0 with: - node_image: kindest/node:v1.18.8 + node_image: kindest/node if: steps.list-changed.outputs.changed == 'true' - name: Run chart-testing (install) - run: ct install --debug --config test.yaml \ No newline at end of file + run: ct install --debug --config test.yaml From 7f635a8140b32491e28b4014faeb513c39b525cd Mon Sep 17 00:00:00 2001 From: Fernando Maia Date: Wed, 13 Jan 2021 11:16:14 -0300 Subject: [PATCH 10/11] Update KinD to the latest version --- .github/workflows/lint-test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/lint-test.yml b/.github/workflows/lint-test.yml index 908cfd4..44d1530 100644 --- a/.github/workflows/lint-test.yml +++ b/.github/workflows/lint-test.yml @@ -43,7 +43,7 @@ jobs: - name: Create kind cluster uses: helm/kind-action@v1.1.0 with: - node_image: kindest/node + node_image: kindest/node:v1.20.0 if: steps.list-changed.outputs.changed == 'true' - name: Run chart-testing (install) From b0f137fe43bfcfa07e4560018a1a78bcf31660c0 Mon Sep 17 00:00:00 2001 From: Fernando Maia Date: Wed, 13 Jan 2021 11:20:06 -0300 Subject: [PATCH 11/11] Update KinD to the latest version --- .github/workflows/lint-test.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/lint-test.yml b/.github/workflows/lint-test.yml index 44d1530..170aeff 100644 --- a/.github/workflows/lint-test.yml +++ b/.github/workflows/lint-test.yml @@ -42,8 +42,6 @@ jobs: - name: Create kind cluster uses: helm/kind-action@v1.1.0 - with: - node_image: kindest/node:v1.20.0 if: steps.list-changed.outputs.changed == 'true' - name: Run chart-testing (install)