This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix error property propagation from background pages #9693
Labels
browser-extension
debt
Technical debt.
estimate/1d
integrations
planned/3.16
Issues that were planned for the given milestone. Used by cmd/tracking-issue.
Comments
This was referenced Apr 9, 2020
Merged
Dear all, This is your release captain speaking. 🚂🚂🚂 Branch cut for the 3.16 release is scheduled for tomorrow. Is this issue / PR going to make it in time? Please change the milestone accordingly. Thank you |
lguychard
added
the
planned/3.16
Issues that were planned for the given milestone. Used by cmd/tracking-issue.
label
May 18, 2020
17 tasks
Dear all, This is your release captain speaking. 🚂🚂🚂 Branch cut for the 3.17 release is scheduled for tomorrow. Is this issue / PR going to make it in time? Please change the milestone accordingly. Thank you |
4 tasks
Heads up @Joelkw @felixfbecker - the "team/extensibility" label was applied to this issue. |
45 tasks
This is probably still an issue and would improve our tooling if fixed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
browser-extension
debt
Technical debt.
estimate/1d
integrations
planned/3.16
Issues that were planned for the given milestone. Used by cmd/tracking-issue.
Currently, errors that go through the background-content-page boundary lose their error name: mozilla/webextension-polyfill#210. This means we need to use hacky string message assertion and cannot include any other context.
This has caused multiple bugs (e.g. #9411, #7599, ...) and many hours of engineering time lost.
names could always be propagated, custom properties are a bit more tricky because they may not be cloneable.
The text was updated successfully, but these errors were encountered: