Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

Fix error property propagation from background pages #9693

Open
1 of 2 tasks
felixfbecker opened this issue Apr 9, 2020 · 4 comments
Open
1 of 2 tasks

Fix error property propagation from background pages #9693

felixfbecker opened this issue Apr 9, 2020 · 4 comments
Assignees
Labels
browser-extension debt Technical debt. estimate/1d integrations planned/3.16 Issues that were planned for the given milestone. Used by cmd/tracking-issue.

Comments

@felixfbecker
Copy link
Contributor

felixfbecker commented Apr 9, 2020

Currently, errors that go through the background-content-page boundary lose their error name: mozilla/webextension-polyfill#210. This means we need to use hacky string message assertion and cannot include any other context.
This has caused multiple bugs (e.g. #9411, #7599, ...) and many hours of engineering time lost.

names could always be propagated, custom properties are a bit more tricky because they may not be cloneable.

@uwedeportivo
Copy link
Contributor

Dear all,

This is your release captain speaking. 🚂🚂🚂

Branch cut for the 3.16 release is scheduled for tomorrow.

Is this issue / PR going to make it in time? Please change the milestone accordingly.
When in doubt, reach out!

Thank you

@lguychard lguychard added the planned/3.16 Issues that were planned for the given milestone. Used by cmd/tracking-issue. label May 18, 2020
@lguychard lguychard modified the milestones: 3.16, 3.17 May 18, 2020
@uwedeportivo
Copy link
Contributor

Dear all,

This is your release captain speaking. 🚂🚂🚂

Branch cut for the 3.17 release is scheduled for tomorrow.

Is this issue / PR going to make it in time? Please change the milestone accordingly.
When in doubt, reach out!

Thank you

@github-actions
Copy link
Contributor

Heads up @Joelkw @felixfbecker - the "team/extensibility" label was applied to this issue.

@vdavid
Copy link
Contributor

vdavid commented Oct 12, 2022

This is probably still an issue and would improve our tooling if fixed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
browser-extension debt Technical debt. estimate/1d integrations planned/3.16 Issues that were planned for the given milestone. Used by cmd/tracking-issue.
Projects
None yet
Development

No branches or pull requests

6 participants