Skip to content

Commit c682440

Browse files
committed
refac(bin_t%first/last): rm unnecessary arg
1 parent 0e5632f commit c682440

File tree

3 files changed

+6
-8
lines changed

3 files changed

+6
-8
lines changed

src/sourcery/bin_m.f90

+2-4
Original file line numberDiff line numberDiff line change
@@ -26,19 +26,17 @@ elemental module function construct(num_items, num_bins, bin_number) result(bin)
2626

2727
interface
2828

29-
elemental module function first(self, bin_number) result(first_item_number)
29+
elemental module function first(self) result(first_item_number)
3030
!! the result is the first item number associated with the given bin
3131
implicit none
3232
class(bin_t), intent(in) :: self
33-
integer, intent(in) :: bin_number
3433
integer first_item_number
3534
end function
3635

37-
elemental module function last(self, bin_number) result(last_item_number)
36+
elemental module function last(self) result(last_item_number)
3837
!! the result is the last item number associated with the given bin
3938
implicit none
4039
class(bin_t), intent(in) :: self
41-
integer, intent(in) :: bin_number
4240
integer last_item_number
4341
end function
4442

src/sourcery/data_partition_s.f90

+2-2
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,12 @@
1515

1616
module procedure first
1717
call assert( allocated(bin), "data_partition_s(first): allocated(bin)")
18-
first_index = bin(image_number)%first(image_number)
18+
first_index = bin(image_number)%first()
1919
end procedure
2020

2121
module procedure last
2222
call assert( allocated(bin), "data_partition_s(last): allocated(bin)")
23-
last_index = bin(image_number)%last(image_number)
23+
last_index = bin(image_number)%last()
2424
end procedure
2525

2626
module procedure gather_real32_1D_array

test/bin_test.f90

+2-2
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ function verify_block_partitioning() result(test_passes)
5151
integer b
5252

5353
bins = [( bin_t(num_items=n_items, num_bins=n_bins, bin_number=b), b = 1,n_bins )]
54-
associate(in_bin => [(bins(b)%last(b) - bins(b)%first(b) + 1, b = 1, n_bins)])
54+
associate(in_bin => [(bins(b)%last() - bins(b)%first() + 1, b = 1, n_bins)])
5555
associate(remainder => mod(n_items, n_bins), items_per_bin => n_items/n_bins)
5656
test_passes = all([(in_bin(1:remainder) == items_per_bin + 1)]) .and. all([(in_bin(remainder+1:) == items_per_bin)])
5757
end associate
@@ -69,7 +69,7 @@ function verify_all_items_partitioned() result(test_passes)
6969
integer b
7070

7171
bins = [( bin_t(num_items=n_items, num_bins=n_bins, bin_number=b), b = 1,n_bins )]
72-
test_passes = sum([(bins(b)%last(b) - bins(b)%first(b) + 1, b = 1, n_bins)]) == n_items
72+
test_passes = sum([(bins(b)%last() - bins(b)%first() + 1, b = 1, n_bins)]) == n_items
7373

7474
end function
7575

0 commit comments

Comments
 (0)