Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper use of rendering loaded components from the IO container #6

Open
rmrhz opened this issue Jul 29, 2014 · 5 comments
Open

Proper use of rendering loaded components from the IO container #6

rmrhz opened this issue Jul 29, 2014 · 5 comments

Comments

@rmrhz
Copy link
Contributor

rmrhz commented Jul 29, 2014

As the title proposed, we were left blinded out that we should resolve a new instance of class that is already present in the IO container, in fact, provided in the API. The $app variable is already inherited in which we can just call $app['instance'] instead of making a new one. A patch will be provided.

@srph
Copy link
Member

srph commented Jul 29, 2014

It does not cause an app a considerable amount of overhead, right? This is regarding the injection of the App instance.

@rmrhz
Copy link
Contributor Author

rmrhz commented Jul 29, 2014

No, compared to the use of $app->make, since we don't need to make another new instance. The old implementation is rather flawed. I didn't saw it coming.

@srph
Copy link
Member

srph commented Jul 29, 2014

How about the injection of the App instance? Negligible overhead?

@srph
Copy link
Member

srph commented Jul 29, 2014

Won't it be much better to inject $app instead of using this library?

@rmrhz
Copy link
Contributor Author

rmrhz commented Jul 29, 2014

How about the injection of the App instance? Negligible overhead?

Elaborate. You're just asking questions without context

Won't it be much better to inject $app instead of using this library?

Yes you can, this library might serve as a reference instead.

lightshire added a commit that referenced this issue Aug 4, 2014
@srph srph mentioned this issue Aug 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants