Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify and fix bugs of bootstrap json file generating script #40

Merged
merged 9 commits into from
Oct 18, 2024

Conversation

haampie
Copy link
Member

@haampie haampie commented Oct 18, 2024

  • condense 3 almost identical scripts into 1, to reduce the likelihood of bugs
  • for abstract specs record {name}{@version}{%compiler.name} platform={platform} target={target} [^python@version]. This fixes a bug where previously gnupg would record the range @2.3: instead of @2.3. Spack on install looks for intersection of the abstract spec with its requirement; would there ever be a CVE in gnupg, we'd bump on Spack's side the range to say @2.6:, which would not intersect with @2.3, and cause bootstrapping from sources.
  • the python key is removed for clingo, and ^python is recorded in spec instead, which is not breaking:
    https://github.com/spack/spack/blob/d36452cf4e70fa1da8b9db43921850872b82ced9/lib/spack/spack/bootstrap/core.py#L199-L207
  • bump spack version to include spack/spack@d36452c

@alalazo alalazo merged commit 299786a into main Oct 18, 2024
25 checks passed
@alalazo alalazo deleted the hs/fix/bugs-in-bootstrap-json branch October 18, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants