Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add centralized config #112

Open
cmelone opened this issue Oct 2, 2024 · 0 comments · May be fixed by #133
Open

Add centralized config #112

cmelone opened this issue Oct 2, 2024 · 0 comments · May be fixed by #133
Assignees
@cmelone
Labels
config Modifications to App Configuration

Comments

@cmelone
Copy link
Collaborator

cmelone commented Oct 2, 2024

Problem/Opportunity Statement

We define constants in code that are technically preferences of the authors, they should be decoupled to allow for customization.

example:

spack-gantry/gantry/routes/prediction/prediction.py

Lines 10 to 22 in efd78ca

IDEAL_SAMPLE = 5
DEFAULT_CPU_REQUEST = 1
DEFAULT_MEM_REQUEST = 2 * 1_000_000_000 # 2GB in bytes
EXPENSIVE_VARIANTS = {
"sycl",
"mpi",
"rocm",
"cuda",
"python",
"fortran",
"openmp",
"hdf5",
}

What would success / a fix look like?

Nothing fancy, maybe an optional config.py under gantry/.
@cmelone cmelone added the config Modifications to App Configuration label Oct 2, 2024
@cmelone cmelone self-assigned this Oct 2, 2024
cmelone added a commit that referenced this issue Nov 13, 2024
@cmelone
Store consts in one file
750410c 
Closes #112

Decouples configuration from code in a centralized manner.
@cmelone cmelone linked a pull request Nov 13, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmelone cmelone

Labels
config Modifications to App Configuration
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Store consts in one file spack/spack-gantry
1 participant
@cmelone