-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only rebuild images that could have changed #618
base: main
Are you sure you want to change the base?
Only rebuild images that could have changed #618
Conversation
e6815e6
to
b2b5dc5
Compare
I tested this stuff with a different workflow and rules since the way we have this workflow now, it only runs when pushing to In there if you look through the jobs, you can see that the I wish there were an early exit option for jobs, instead of having to put an |
b2b5dc5
to
1457fe4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. It might be worth looking into whether we can use https://github.com/dorny/paths-filter instead (maybe that was the action you were referring to earlier). And then use the output from that action to build the job matrix dynamically. Sort of how it's done here https://stackoverflow.com/a/65434401. Might be something to put on the backlog at least depending on how high of a priority this is, but I think this solution is sufficient for our purposes now
It was actually this one I meant, which looks really active, is used by a lot of people, and has more features.
Yeah, I wanted to do that too, once I saw this workflow in change-actions repo, I wondered how we could do that in our case. Just need to figure out how to continue using our manually incremented tags in that scenario, but I didn't really try yet. I'll give it a go, as it would be nice to skip altogether the jobs we don't need. |
The goal here is to only rebuild images that might actually need to be rebuilt, based on what files changed. I suggested I would do this here, see that discussion for more background.