Add vectors by value #119
Merged
Add vectors by value #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbarrielle
reviewed
Oct 27, 2017
There was a problem hiding this comment.
Looks good, just one nitpick (but it's actually my fault): CsVec is in fact generic over the index type, so IS1 should have the bound IS1: I where I: SpIndex.
Looks like I had forgotten to propagate this change in the addition trait, which is probably why it's also present in your PR.
If you wish to fix that before I merge the PR, go ahead, otherwise I will merge it and fix it afterwards.
Thanks!
src/sparse/vec.rs
Outdated
| impl<N, IS1, DS1, IS2, DS2> Add<CsVecBase<IS2, DS2>> | ||
| for CsVecBase<IS1, DS1> | ||
| where N: Copy + Num, | ||
| IS1: Deref<Target=[usize]>, |
There was a problem hiding this comment.
IS1 could be deref on a generic Index type, as in https://github.com/vbarrielle/sprs/blob/master/src/sparse/vec.rs#L814-L823
There was a problem hiding this comment.
Will fix it with the PR, while I am at it ;)
|
That's perfect, thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first tiny step towards #118.
alga's
ClosedAddtrait requires addition by value. These implementations merely delegate to the by-reference implementation. I imagine that there is some space for optimization here later on, if you take ownership of the operands.The same considerations apply for the other operators, too. I'd be happy to apply the procedure to all of them (could be done in this PR), but I would like to get feedback on this approach first.