Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore tests that were commented out due to upgrade and code quality efforts #386

Open
benpsnyder opened this issue Sep 24, 2024 · 0 comments
Open

Restore tests that were commented out due to upgrade and code quality efforts #386

benpsnyder opened this issue Sep 24, 2024 · 0 comments
Assignees
@goetzrobin
Labels
bug Something isn't working

Comments

@benpsnyder
Copy link
Collaborator

benpsnyder commented Sep 24, 2024 •
edited
Loading

Need to restore functionality for tests in

  • carouself.cy.ts
  • combobox.cy.ts
  • command--default.cy.ts
  • select.cy.ts
  • dropdown-menu.cy.ts

Search for TODO: @benpsnyder or TODO: @goetzrobin
@benpsnyder benpsnyder added the bug Something isn't working label Sep 24, 2024
This was referenced Nov 22, 2024
Merged
Merged
MerlinMoos pushed a commit to MerlinMoos/spartan that referenced this issue Nov 22, 2024
refactor(context-menu): migrate to signals (spartan-ng#418) (spartan-…
ba7a0b9 
…ng#386)
dongphuong0905 pushed a commit to dongphuong0905/spartan that referenced this issue Nov 23, 2024
@dongphuong0905
refactor(context-menu): migrate to signals (spartan-ng#418) (spartan-…
b74e7b8 
…ng#386)
dongphuong0905 added a commit to dongphuong0905/spartan that referenced this issue Nov 23, 2024
@dongphuong0905
feat(breadcrumb): Add breadcrumb component
ec4d42e 
feat(breadcrumb): fix review comment

feat(breadcrumb): fix storybook

fix(select): updating trigger width on element resize

fix(select): updating trigger width on element resize

refactor(separator): migration to signals (spartan-ng#449)

* refactor(separator): migration to signals

Covered areas: BrnSeparatorComponent
Already using signals: HlmSeparatorDirective

* refactor(separator): revert renaming of orientation and improve types

* docs(separator): add default values to storybook

refactor(switch): signal migration (spartan-ng#468)

* refactor(switch): signal migration

* fix: disabled state

* refactor: removing rxhostlistener

refactor(accordion): migration to signals (spartan-ng#461)

docs(select): add missing css import (spartan-ng#444)

* docs(select): add missing css import

Add the css import '@angular/cdk/overlay-prebuilt.css' (necessary for the component to function properly) in the documentation

* docs(select): add missing css import

Add the css import '@angular/cdk/overlay-prebuilt.css' (necessary for the component to function properly) in the documentation

refactor(avatar)!: migration to signals (spartan-ng#445)

* refactor(avatar): migration to signals

Covered areas:
- HlmAvatarComponent (with updated tests)
- BrnAvatarComponent
- BrnAvatarFallbackDirective

Already using signals:
- HlmAvatarImageDirective
- HlmAvatarFallbackDirective
- BrnAvatarImageDirective

* refactor(avatar): switch to new control flow syntax

* refactor(avatar): update templates manually for the generator

* refactor(avatar): rename inputs to be simpler, dropping the alias

BREAKING CHANGE: Renamed useAutoColor to autoColor, userCls to userClass

Closes spartan-ng#415

refactor(button)!: migration to signals (spartan-ng#447)

* refactor(button): migration to signals

* refactor(button): migration to signals

* refactor(button): migration to signals

* refactor(button): migration to signals

* refactor(button): migration to signals

* refactor(button): migration to signals

* refactor(button): migration to signals

refactor(badge): migration to signals (spartan-ng#454)

* refactor(badge): migration to signals

Closes spartan-ng#419

* docs(badge): add default values to storybook

chore(carousel): update embla-carousel-angular to v18 (spartan-ng#410)

refactor(progress): migration to signals (spartan-ng#455)

refactor(progress): migration to signals

refactor(pagination): migration to signals (spartan-ng#457)

* refactor(pagination): migration to signals

* refactor(pagination): migration to signals

refactor(scroll-area): migration to signals (spartan-ng#448)

* refactor(scroll-area): migration to signals

* refactor(scroll-area): improve input types for boolean transforms

* docs(scroll-area): add default values to storybook

refactor(sonner): follow conventions and improve type safety (spartan-ng#470)

refactor(accordion): remove triggers check, always defined as signal (spartan-ng#473)

refactor(tabs): migration to signals (spartan-ng#462)

* refactor(tabs): migration to signals

* refactor(tabs): format

* refactor(tabs): migration to signals

* refactor(tabs): remove unused triggers check, triggers is always defined as signal

refactor(label): migration to signals (spartan-ng#469)

refactor(alert): migrate to signals

Revert "refactor(alert): migrate to signals"

This reverts commit 250a74b.

refactor(alert): migrate to signals (spartan-ng#479)

refactor(icon): migrate to signals (spartan-ng#477)

refactor(checkbox): migration to signals (spartan-ng#474)

* refactor(checkbox): migration to signals

* refactor(checkbox): migration to signals

* compute state for disabled input and override it internally

refactor(toggle): migrate to signals (spartan-ng#472)

* refactor(toggle): migrate to signals

* refactor(toggle): migrate to signals

docs(tooltip): add simple string tooltip example (spartan-ng#390)

Co-authored-by: Oleh <[email protected]>

feat(breadcrumb): fix formatting

feat(breadcrumb): add page nav

feat(breadcrumb): fix review comments

feat(breadcrumb): reorder breadcrumb by alphabet

feat(breadcrumb): fix e2e test

feat(breadcrumb): fix review comments

feat(breadcrumb): update breadcrumb separator

feat(breadcrumb): fix format code

feat(collapsible)!: migrate collapsible to signals (spartan-ng#481)

refactor(input): migrate to signals (spartan-ng#475)

* refactor(input): migrate to signals

* refactor(input): change form field controls to public

* refactor(input): use input instead of signal for error

fix(toggle): sync initial internal toggle group state when toggle con… (spartan-ng#482)

* fix(toggle): sync initial internal toggle group state when toggle content children become available

closes spartan-ng#408

* refactor(toggle): remove imperative calls to updateSelectionState (spartan-ng#484)

---------

Co-authored-by: Benjamin Heiss <[email protected]>

fix(avatar): remove unused NgIf import (spartan-ng#486)

fix: 300 mobile responsiveness (spartan-ng#487)

adds missing spartans

feat(calendar): calendar component (spartan-ng#480)

build: moving to pnpm, eslint and prettier (spartan-ng#483)

feat(breadcrumb): fix format

feat(breadcrumb): update eslint path

feat(breadcrumb): fix lint

feat(breadcrumb): sort import

feat(breadcrumb): fix lint for breadcrumb page

docs(tooltip): remove unused import (spartan-ng#491)

docs(dialog): update docs for dialogs with dynamic content (spartan-ng#494)

refactor(pagination): ariaLabel and text as input for localization (spartan-ng#498)

refactor(context-menu): migrate to signals (spartan-ng#418)

refactor(context-menu): migrate to signals (spartan-ng#418)

refactor(context-menu): migrate to signals (spartan-ng#418)

refactor(context-menu): migrate to signals (spartan-ng#418) (spartan-ng#386)
@dongphuong0905 dongphuong0905 mentioned this issue Nov 23, 2024
Closed
@goetzrobin goetzrobin self-assigned this Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@goetzrobin goetzrobin

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benpsnyder @goetzrobin