autorun job doesn't fail if Gerrit vote with curl fails due to wrong password #24
Comments
jimharris
added a commit
that referenced
this issue
Oct 24, 2024
Without this, Gerrit does a response, so curl just returns 0. But we want it to actually interpret the response, and exit with error for things like a 401 (Unauthorized). Fixes issue #24. Signed-off-by: Jim Harris <[email protected]> Change-Id: I5eaefd6f7fe1bf2f46ecf25064078e8d15ab9818
jimharris
added a commit
that referenced
this issue
Oct 24, 2024
Without this, Gerrit does a response, so curl just returns 0. But we want it to actually interpret the response, and exit with error for things like a 401 (Unauthorized). Fixes issue #24. Signed-off-by: Jim Harris <[email protected]> Change-Id: I5eaefd6f7fe1bf2f46ecf25064078e8d15ab9818
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If we try to vote on a patch, and it fails due to an unauthorized response, curl by default returns 0, and the autorun job passes.
We need to pass
--fail-with-bodyto curl, then it will interpret the response and exit with error for things like an unauthorized (404) response.The text was updated successfully, but these errors were encountered: