Unit test failure - test_post_submit

[goneall]

The following test_post_submit unit test fails on the master branch:

======================================================================
FAIL: test_post_submit (app.tests.SubmitNewLicenseViewsTestCase)
POST Request for submit a new license
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/spdx-online-tools/spdx-online-tools/src/app/tests.py", line 1229, in test_post_submit
    self.assertEqual(resp.status_code,200)
AssertionError: 500 != 200

[Ugtan]

@goneall I'm getting a different error in my machine.

FYI, All the test cases that are failing are the once that were skipped because they require github credentials which is why these tests were not tested. I will take a look at it.

[goneall]

FYI, All the test cases that are failing are the once that were skipped because they require github credentials which is why these tests were not tested. I will take a look at it.

I added the credentials to Git a couple weeks back - this may have exposed an issue that was introduced some time ago. The errors are coming from the automated Git actions on checkin.

@Ugtan Thanks for looking into the issue.

[SidharajYadav]

How i can contribute
please guide me
I like to solve this problem

[BanulaKumarage]

Hi @goneall can you clarify the difference between test_post_submit and test_submit_new_license

[goneall]

@BanulaKumarage Probably a better question for @rtgdk - I'm not as familiar with the unit test code

[BanulaKumarage]

Hi @goneall I made a pr to fix this issue. Can you review it?

[rtgdk]

@BanulaKumarage test_submit_new_license is the test for get request on submit-new-license page while test_post_submit tests the post request. Both of them have different functionalities

• get -> retrivies page and check the form is displayed with correct values
• post -> checks with correct data license is submitted successfully

[BanulaKumarage]

Thank you @rtgdk. I got the idea

[jlovejoy]

@rtgdk - what is the status of this?