Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

License XML editor assumes fork is named license-list-XML #430

Open
goneall opened this issue Feb 6, 2023 · 2 comments
Open

License XML editor assumes fork is named license-list-XML #430

goneall opened this issue Feb 6, 2023 · 2 comments
Labels
Submit New License Issues related to the submit new license feature

Comments

@goneall
Copy link
Member

goneall commented Feb 6, 2023

When using the "License XML Editor" "Submit Changes" feature, if the user's fork of the license-list-XML repo is not named precisely license-list-XML, the submission will fail with a very generic error message.

The problem is in the makePullRequest code.
@jlovejoy jlovejoy added the Submit New License Issues related to the submit new license feature label Mar 9, 2023
@BassCoder2808
Copy link
Contributor

Hi @goneall I would like to work on this issue if it is still open, it would be really helpful if you could help me in getting started with it, like how to replicate the error and what is the intended output for the same

@jlovejoy
Copy link
Member

I think this might fall into the "better toast messages" category??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Submit New License Issues related to the submit new license feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@goneall @jlovejoy @BassCoder2808