Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link of the GitHub Issue from the License Information page #453

Open
BanulaKumarage opened this issue Mar 29, 2023 · 9 comments
Open
Labels
Submit New License Issues related to the submit new license feature

Comments

@BanulaKumarage
Copy link
Contributor

Even though there is a link to access the request of the online tool from the Github issue, there is no link to access the GitHub issue from the online tool.

BanulaKumarage added a commit to BanulaKumarage/spdx-online-tools that referenced this issue Mar 29, 2023
BanulaKumarage added a commit to BanulaKumarage/spdx-online-tools that referenced this issue Mar 29, 2023
BanulaKumarage added a commit to BanulaKumarage/spdx-online-tools that referenced this issue Mar 29, 2023
@BassCoder2808
Copy link
Contributor

Yes, I think this would be helpful to the user as currently, we are only opening a new tab for discussion for the github issues as per Redirect on Successful License Submission.

@BassCoder2808
Copy link
Contributor

Actually, this issue can be closed as #452 intends to solve the same with some other minor changes.

@BanulaKumarage
Copy link
Contributor Author

BanulaKumarage commented Apr 1, 2023

Actually, this issue can be closed as #452 intends to solve the same with some other minor changes.

@BassCoder2808 I think it's good to solve this with #454 instead of solving it under #452

@jlovejoy jlovejoy added the Submit New License Issues related to the submit new license feature label Jun 21, 2023
@jlovejoy jlovejoy changed the title Add link of the GitHub Issue to the License Information page Add link of the GitHub Issue from the License Information page Jun 21, 2023
@jlovejoy
Copy link
Member

add link to Github issue created from license submission to list of submitted licenses at https://tools.spdx.org/app/license_requests/

@BassCoder2808 - has this been solved for and merged?

@BassCoder2808
Copy link
Contributor

Hi @jlovejoy actually there has been some miscommunications like there are 2 issues and 2 PRs that solve the 2 issues separately which in the end intend to do the same task.
So what I feel is that we can move forward with #452 (just because it was opened earlier and solves one more issue)
and the PR to move forward with #456

@jlovejoy
Copy link
Member

@BassCoder2808 - I"m confused this issue is about adding the Github link to the license info page and #452 is about removing the Standard License Header field from the output in the issue, so I think we should leave both issues?

but is it that the PR #456 solves both of these issues?

@BassCoder2808
Copy link
Contributor

Hi @jlovejoy yes actually #452 the issue which you had created also intended to do the same.
Yes, #456 intends to solve both the task which you have mentioned above regarding the "Standard License Header" as well as the "open issue on new tab"

@jlovejoy
Copy link
Member

was this issue intended to add a link to the Github issue to individual license pages in the tool like https://tools.spdx.org/app/license_requests/251/
or to the list here https://tools.spdx.org/app/license_requests/ ?

I was thinking the latter, but in any case, it is not there, so I don't think this is resolved yet

@BassCoder2808
Copy link
Contributor

As far as I remember @jlovejoy this was intended to open a new issues tab for that particular issue only because my thinking was that, the user will be focused on the currently submitted license only and not towards the general list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Submit New License Issues related to the submit new license feature
Projects
None yet
Development

No branches or pull requests

3 participants