You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The semantic_version library has been added as a dependency but none of its features are used. Why adding a dependency when storing a simple string is just as good?
The text was updated successfully, but these errors were encountered:
I'm also a +1 for removing a unused dependency. (NOTE: I thought "none of its features are used" meant that the dependency is unused.)
That said, I did a quick check for how many mentions of semantic_version show up in the codebase and I found six instances. The GitHub UI search functionality agrees and also adds the instance in which the dependency is mentioned in the pyproject.toml file.
But perhaps your comment is really that the functionality of the semantic_version module is used too lightly. My scan suggests that only the Version class is used.
While I defer to you and others that have a history with this project, it does strike me that one benefit of using the semantic_version 3rd party library is that this library does do a check for whether the version actually follows the semantic version scheme. Whether that benefit outweighs the costs of adding a dependency, I defer to others.
The semantic_version library has been added as a dependency but none of its features are used. Why adding a dependency when storing a simple string is just as good?
The text was updated successfully, but these errors were encountered: