Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused semantic_version module #802

Open
pombredanne opened this issue Mar 22, 2024 · 1 comment
Open

Remove unused semantic_version module #802

pombredanne opened this issue Mar 22, 2024 · 1 comment

Comments

@pombredanne
Copy link
Member

The semantic_version library has been added as a dependency but none of its features are used. Why adding a dependency when storing a simple string is just as good?

@jspeed-meyers
Copy link
Contributor

I'm also a +1 for removing a unused dependency. (NOTE: I thought "none of its features are used" meant that the dependency is unused.)

That said, I did a quick check for how many mentions of semantic_version show up in the codebase and I found six instances. The GitHub UI search functionality agrees and also adds the instance in which the dependency is mentioned in the pyproject.toml file.

$ grep -r -o "semantic_version" --include="*.py" | wc -l
6

This library does in fact appear to be used.

But perhaps your comment is really that the functionality of the semantic_version module is used too lightly. My scan suggests that only the Version class is used.

While I defer to you and others that have a history with this project, it does strike me that one benefit of using the semantic_version 3rd party library is that this library does do a check for whether the version actually follows the semantic version scheme. Whether that benefit outweighs the costs of adding a dependency, I defer to others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants