Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can add a loan preparation without a quantity #6050

Open
combs-a opened this issue Jan 8, 2025 · 0 comments
Open

Can add a loan preparation without a quantity #6050

combs-a opened this issue Jan 8, 2025 · 0 comments
Labels
1 - Bug Incorrect behavior of the product 2 - Interactions Issues that are related to interactions, including loans, exchanges, gifts, and more

Comments

@combs-a
Copy link
Collaborator

combs-a commented Jan 8, 2025

Describe the bug
You can empty out the Selected field when selecting preparations for a new loan and save it without a quantity. Furthermore, you can empty the quantity field on a existing loan and still save.

Unsure if the second behavior is intended (because you don't get a save blocker when having the field empty or 0 on an existing loan), but the first one definitely isn't. When creating a new loan, setting the value to 0 means that it shouldn't be selected. This is effectively the same case.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Interactions -> Loan
  2. Choose either record set or catalog number
  3. At the list of preparations, empty one of the Selected fields
  4. See that even though it's empty, it's now checked
  5. Click apply and see that it goes through
  6. Add a loan number
  7. Try to save, see that a save blocker pops up for a second
  8. Click somewhere else on the form and see that the save blocker is cleared and you can now save

Expected behavior
Similar to negative numbers and numbers larger than the amount of preparations, this should not be allowed; preferably clicking Apply should block this.

Screenshots

badloan.mp4

Please fill out the following information manually:

  • OS: Windows 10
  • Browser: Firefox and Chrome
  • Specify 7 Version: production (v7.9.11) and v7.9.6.2
  • Database Name: sdnhm_herps_2_8_24
  • Collection name: Herp-PC
  • User Name: testuser
  • URL: N/A
@combs-a combs-a added 1 - Bug Incorrect behavior of the product 2 - Interactions Issues that are related to interactions, including loans, exchanges, gifts, and more labels Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - Bug Incorrect behavior of the product 2 - Interactions Issues that are related to interactions, including loans, exchanges, gifts, and more
Projects
None yet
Development

No branches or pull requests

1 participant