Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No protections for deleting a rank from tree def item subform dialog #6057

Open
bronwyncombs opened this issue Jan 9, 2025 · 0 comments
Open
Labels
1 - Bug Incorrect behavior of the product 2 - Trees Issues that are related to the tree system and related functionalities. 2 - User Interface Issues that are related to the user interface or user experience.

Comments

@bronwyncombs
Copy link

Describe the bug
A clear and concise description of what the bug is.

there is no warning/confirmation when deleting a tree rank (with or without nodes) when going through the subform dialog accessed via the tree edit dialog.

Although you have to save back on the edit tree dialog after deleting, a warning should still be in place when the minus is clicked since the user can't review the changes made before saving and might not notice or remember such changes before saving them.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Tree
  2. Observe deletion behavior when clicking pencil by rank name (after entering edit mode)
  3. Now click on pencil by tree name
  4. Click tree def items to pull up the subform dialog
  5. Click red minus icon on rank
  6. See no warning

Expected behavior

A warning/confirmation dialog should appear in all cases of tree rank deletion. Either removing the ability to delete from this workflow and isolating action to individual rank's edit dialog or adjusting the minus button to warn upon clicking.

Screenshots

dialog with warning from rank edit pencil
Screenshot 2025-01-09 at 10 33 23 AM

comparing behavior b/t rank edit pencil and tree edit pencil workflows

Screen.Recording.2025-01-09.at.10.35.21.AM.mp4

Please fill out the following information manually:

Reported By
Robyn @ RBGE

I created the new rank, but it went at a position in the tree that I didn’t want (at the lowest available rank). I then removed it, but was surprised there wasn’t a prompt when pressing the red minus – for such a key item it felt like this should have a confirmation prompt. Whilst I realise it doesn’t save at that point, it felt odd that there wasn’t some sort of confirmation needed at that point. I think the current functionality is the same as the same across the system, however it felt like something linked to a tree needed more protection.

@bronwyncombs bronwyncombs added 1 - Bug Incorrect behavior of the product 2 - Trees Issues that are related to the tree system and related functionalities. 2 - User Interface Issues that are related to the user interface or user experience. labels Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - Bug Incorrect behavior of the product 2 - Trees Issues that are related to the tree system and related functionalities. 2 - User Interface Issues that are related to the user interface or user experience.
Projects
None yet
Development

No branches or pull requests

1 participant