Skip to content

Attachments Not Yet Being Requested But Skeleton Loading #3567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
carlosmbe opened this issue Jun 2, 2023 · 6 comments · May be fixed by #6400
Open

Attachments Not Yet Being Requested But Skeleton Loading #3567

carlosmbe opened this issue Jun 2, 2023 · 6 comments · May be fixed by #6400
Labels
1 - Bug Incorrect behavior of the product

Comments

@carlosmbe
Copy link
Contributor

Describe the bug
The attachments at the far bottom of the video are not yet being requested as we haven't scrolled that far down yet. However, it looks like they're loading. Which can be a bit confusing.

As far as I can tell, it's not really a "Scale" Issue since this was the default on both.

To Reproduce
Steps to reproduce the behavior:

  1. Go to NHMD Test -> Amber(Any collection is fine really)
  2. Click on Attachments
  3. See error
  4. Scroll Down to observe what I mean by "they were not yet requested`

Expected behavior
Pre Skeleton Load Versions loaded attachments till just under the viewable section. Here is an example of V 7.8.2
It has it's own issues but it illustrates well enough

Screen.Recording.2023-06-02.at.2.14.41.PM.mov

Screen Recording of Our Issue

CHipped.Ending.mp4

Desktop:

  • OS: Mac OsX Ventura
  • Browser: Chrome
  • Specify 7 Version: 7.8.12 Pre Release

Database Name: Using NHMD Test here

Here are reference shots of when each row has the same number on each version
SMALLEST ON SCALE
Screenshot 2023-06-02 at 2 31 02 PM
Screenshot 2023-06-02 at 2 30 53 PM

6 By Row
Screenshot 2023-06-02 at 2 34 24 PM
Screenshot 2023-06-02 at 2 34 36 PM

@carlosmbe carlosmbe added 1 - Bug Incorrect behavior of the product pri:unknown labels Jun 2, 2023
@carlosmbe
Copy link
Contributor Author

Using 7.8.2 may have been extreme but 7.8.11 still uses progress bars so the results are similar

@melton-jason
Copy link
Contributor

Currently, the number of skeleton squares shown is the Default Fetch Limit of Specify 7 (20).
This is also how many Attachments will be fetched when you scroll down far enough from the page.

Additional Attachments will be fetched when the scroll bar is a certain distance from the bottom. Thus the issue arises when you have a large scale for Attachments. You have to scroll further to reach the 'bottom' and there are always 20 Skeleton Squares.

@carlosmbe Do you have any suggestions to how this should be changed?

Do you think there should be no skeletons in the Attachment Gallery?

Personally, I think the skeletons are nice, but either the amount of scroll-distance distance before they are fetched or the amount of squares themselves should adjust based on the scale set in the Attachment Gallery.

@melton-jason
Copy link
Contributor

Alternatively, we can only show the skeleton squares when they are being fetched.
Similarly to how the Query Builder loads its results

@maxpatiiuk
Copy link
Member

either the amount of scroll-distance distance before they are fetched or the amount of squares themselves should adjust based on the scale set in the Attachment Gallery.

Alternatively, we can only show the skeleton squares when they are being fetched.
Similarly to how the Query Builder loads its results

Yes, this is an oversight of the attachment fetching code I wrote. Both of the solutions you proposed are nice, though the first one is likely better as it would reduce amount of layout shifts happening

@grantfitzsimmons
Copy link
Member

This issue is still pretty annoying... users don't often recognize the issue but I see it often

@emenslin
Copy link
Collaborator

emenslin commented Aug 5, 2024

Can recreate in edge (7.9.6)

@alesan99 alesan99 linked a pull request Apr 8, 2025 that will close this issue
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - Bug Incorrect behavior of the product
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants